fix: add missing signature controller types for mobile #4822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Following removal of message manager usage, update signature controller types that were relied on by mobile, some of which were never reflected in the original types and method signatures.
Specifically:
version
toMessageParamsTyped
.metamaskId
toMessageParams
.request
andsigningOptions
optional innewUnsignedX
methods.References
Changelog
@metamask/signature-controller
metamaskId
toMessageParams
.version
toMessageParamsTyped
.request
argument optional innewUnsignedPersonalMessage
andnewUnsignedTypedMessage
.signingOptions
argument optional innewUnsignedTypedMessage
.Checklist