Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing signature controller types for mobile #4822

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 21, 2024

Explanation

Following removal of message manager usage, update signature controller types that were relied on by mobile, some of which were never reflected in the original types and method signatures.

Specifically:

  • Add version to MessageParamsTyped.
  • Add metamaskId to MessageParams.
  • Make request and signingOptions optional in newUnsignedX methods.

References

Changelog

@metamask/signature-controller

  • ADDED: Add metamaskId to MessageParams.
  • ADDED: Add version to MessageParamsTyped.
  • CHANGED: Make request argument optional in newUnsignedPersonalMessage and newUnsignedTypedMessage.
  • CHANGED: Make signingOptions argument optional in newUnsignedTypedMessage.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Add metamaskId and version to message params.
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-557a8fcb",
  "@metamask-previews/address-book-controller": "6.0.1-preview-557a8fcb",
  "@metamask-previews/announcement-controller": "7.0.1-preview-557a8fcb",
  "@metamask-previews/approval-controller": "7.1.0-preview-557a8fcb",
  "@metamask-previews/assets-controllers": "38.3.0-preview-557a8fcb",
  "@metamask-previews/base-controller": "7.0.1-preview-557a8fcb",
  "@metamask-previews/build-utils": "3.0.1-preview-557a8fcb",
  "@metamask-previews/chain-controller": "0.1.3-preview-557a8fcb",
  "@metamask-previews/composable-controller": "9.0.1-preview-557a8fcb",
  "@metamask-previews/controller-utils": "11.3.0-preview-557a8fcb",
  "@metamask-previews/ens-controller": "14.0.1-preview-557a8fcb",
  "@metamask-previews/eth-json-rpc-provider": "4.1.5-preview-557a8fcb",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-557a8fcb",
  "@metamask-previews/json-rpc-engine": "10.0.0-preview-557a8fcb",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.4-preview-557a8fcb",
  "@metamask-previews/keyring-controller": "17.2.2-preview-557a8fcb",
  "@metamask-previews/logging-controller": "6.0.1-preview-557a8fcb",
  "@metamask-previews/message-manager": "11.0.0-preview-557a8fcb",
  "@metamask-previews/name-controller": "8.0.1-preview-557a8fcb",
  "@metamask-previews/network-controller": "21.0.1-preview-557a8fcb",
  "@metamask-previews/notification-controller": "7.0.0-preview-557a8fcb",
  "@metamask-previews/notification-services-controller": "0.10.0-preview-557a8fcb",
  "@metamask-previews/permission-controller": "11.0.2-preview-557a8fcb",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-557a8fcb",
  "@metamask-previews/phishing-controller": "12.0.3-preview-557a8fcb",
  "@metamask-previews/polling-controller": "10.0.1-preview-557a8fcb",
  "@metamask-previews/preferences-controller": "13.0.3-preview-557a8fcb",
  "@metamask-previews/profile-sync-controller": "0.9.7-preview-557a8fcb",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-557a8fcb",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-557a8fcb",
  "@metamask-previews/selected-network-controller": "18.0.2-preview-557a8fcb",
  "@metamask-previews/signature-controller": "20.0.0-preview-557a8fcb",
  "@metamask-previews/transaction-controller": "37.3.0-preview-557a8fcb",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-557a8fcb"
}

@matthewwalsh0 matthewwalsh0 merged commit ca4eb19 into main Oct 22, 2024
119 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/signature-controller-mobile-types branch October 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants