Skip to content

chore(constraints): respect ALLOWED_INCONSISTENT_DEPENDENCIES for workspace packages; simplify logic #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

chore(constraints): respect ALLOWED_INCONSISTENT_DEPENDENCIES for workspace packages; simplify logic #4800

merged 1 commit into from
Oct 16, 2024

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 16, 2024

Explanation

Allow configuring yarn constraints to allow exceptions for dependency range consistency checks for workspace dependencies and devDependencies.

References

Changelog

None

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@legobeat legobeat mentioned this pull request Oct 16, 2024
Merged
5 tasks
@legobeat legobeat marked this pull request as ready for review October 16, 2024 00:45
@legobeat legobeat requested a review from a team October 16, 2024 00:45
@legobeat legobeat mentioned this pull request Oct 16, 2024
Merged
4 tasks
@legobeat legobeat force-pushed the constraints-allow-consistent-dependency-ranges-exception-workspace-pkgs branch from 65bc31e to b5815c8 Compare October 16, 2024 00:48
legobeat
legobeat commented Oct 16, 2024
View reviewed changes
@legobeat legobeat changed the title chore: respect ALLOWED_INCONSISTENT_DEPENDENCIES for workspace packages; simplify logic chore(constraints): respect ALLOWED_INCONSISTENT_DEPENDENCIES for workspace packages; simplify logic Oct 16, 2024
@legobeat legobeat force-pushed the constraints-allow-consistent-dependency-ranges-exception-workspace-pkgs branch from b5815c8 to 0aec676 Compare October 16, 2024 08:59
@legobeat legobeat merged commit d106b1a into MetaMask:main Oct 16, 2024
116 checks passed
@legobeat legobeat deleted the constraints-allow-consistent-dependency-ranges-exception-workspace-pkgs branch October 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @cryptodev-2s