fix: change gas limit fallback #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
requested changes
Sep 26, 2024
| @@ -96,7 +96,7 @@ export function addGasBuffer( | |||
| multiplier: number, | |||
| ) { | |||
| const estimatedGasBN = hexToBN(estimatedGas); | |||
| const maxGasBN = hexToBN(blockGasLimit).muln(0.9); | |||
| const maxGasBN = hexToBN(blockGasLimit).muln(0.3); | |||
There was a problem hiding this comment.
Was this also confirmed as a safe value?
There was a problem hiding this comment.
This was not an intended change, removed it.
OGPoyraz
force-pushed
the
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
branch
from
605eb03
to
1e6be12
Compare
…5-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
vinistevam
previously approved these changes
Oct 4, 2024
matthewwalsh0
previously approved these changes
Oct 4, 2024
OGPoyraz
dismissed stale reviews from matthewwalsh0 and vinistevam
via
9c94efb
matthewwalsh0
approved these changes
Oct 4, 2024
…5-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
OGPoyraz
deleted the
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
branch
This was referenced Oct 16, 2024
Merged
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 29, 2024
… on failed gas limit estimations (#27954) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR applies the latest `transaction-controller` version that reduces gas limit fallback. [](https://codespaces.new/MetaMask/metamask-extension/pull/27954?quickstart=1) ## **Related issues** Fixes: MetaMask/core#4739 ## **Manual testing steps** NA ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
](https://codespaces.new/MetaMask/metamask-extension/pull/27954?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations.
References
Fixes: MetaMask/metamask-extension#19692
Changelog
@metamask/transaction-controllerChecklist