Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NOTIFY-1166): only fire callback when account name has changed #4735

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Sep 26, 2024

Explanation

This PR ensures the onAccountNameUpdated callback only fires when the new name is different from the previous one

References

NOTIFY-1166

Changelog

@metamask/profile-sync-controller

  • FIXED: onAccountNameUpdated will now fire only when the new name is different from the previous one

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 26, 2024
@mathieuartu mathieuartu marked this pull request as ready for review September 26, 2024 08:25
@mathieuartu mathieuartu requested a review from a team as a code owner September 26, 2024 08:25
@mathieuartu mathieuartu merged commit 08c7f71 into main Sep 26, 2024
116 checks passed
@mathieuartu mathieuartu deleted the fix/account_sync_analytics branch September 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants