Use selected network controller for Snaps #4602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
adonesky1
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 23, 2024
adonesky1
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 24, 2024
adonesky1
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 27, 2024
adonesky1
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 28, 2024
adonesky1
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Sep 4, 2024
adonesky1
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Sep 11, 2024
Mrtenz
force-pushed
the
mrtenz/snap-networks
branch
from
55328a6 to
207cfd8
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Mrtenz
force-pushed
the
mrtenz/snap-networks
branch
from
207cfd8 to
12ba192
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
FrederikBolding
approved these changes
Feb 17, 2025
adonesky1
reviewed
Apr 21, 2025
packages/selected-network-controller/tests/SelectedNetworkController.test.ts
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
to MetaMask/snaps
that referenced
this pull request
May 15, 2025
This removes `wallet_switchEthereumChain` from the `BLOCKED_RPC_METHODS` list. Closes MetaMask/MetaMask-planning#2938. Closes #2654. Blocked by: - MetaMask/core#4602
Mrtenz
force-pushed
the
mrtenz/snap-networks
branch
from
b31b7b6 to
01668d1
Compare
github-merge-queue bot
pushed a commit
to MetaMask/snaps
that referenced
this pull request
May 15, 2025
This removes `wallet_switchEthereumChain` from the `BLOCKED_RPC_METHODS` list. Closes MetaMask/MetaMask-planning#2938. Closes #2654. Blocked by: - MetaMask/core#4602
Mrtenz
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 19, 2025
Like with websites, we want to support a custom network per Snap rather than relying on the globally selected network. For Snaps, the permission for the network to switch to is automatically granted. [](https://codespaces.new/MetaMask/metamask-extension/pull/26389?quickstart=1) 1. Copy the build files for `@metamask/selected-network-controller` from [this PR](MetaMask/core#4602). 2. Copy the build files for `@metamask/snaps-controllers` and `@metamask/snaps-execution-environments` from [this PR](MetaMask/snaps#2634). 3. Run `test-snaps` for the PR above (`yarn start` in `packages/test-snaps`). 4. Install the Ethereum Provider Example Snap. 5. Switch the chain ID using the `test-snaps` button for the Ethereum Provider example. 6. The Snap should now use the new network, without any permission requests. Step 1 and 2 are no longer necessary once these PRs are merged and released. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/26389?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This removes some checks in the
SelectedNetworkControllerwhich disallow a Snap from using their own network, and default to the globally selected network. After this change, Snaps will be able to select their own network just like websites.References
Related to MetaMask/MetaMask-planning#2938.
Changelog
@metamask/selected-network-controllerChecklist