Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Release 158.0.0 (#4342)" #4350

Merged
merged 1 commit into from
May 31, 2024
Merged

Revert "Release 158.0.0 (#4342)" #4350

merged 1 commit into from
May 31, 2024

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented May 31, 2024

This reverts commit c2e6752.

We need to redo this release because the version set in package.json was wrong and therefore the release did not go out. 🤦🏻

@mcmire mcmire requested review from a team as code owners May 31, 2024 16:22
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Network access npm/@metamask/name-controller@6.0.1
  • orphan: npm/@metamask/name-controller@6.0.1
New author npm/@metamask/queued-request-controller@0.10.0
  • orphan: npm/@metamask/queued-request-controller@0.10.0
Network access npm/@metamask/user-operation-controller@10.0.0
  • orphan: npm/@metamask/user-operation-controller@10.0.0

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/name-controller@6.0.1
  • @SocketSecurity ignore npm/@metamask/queued-request-controller@0.10.0
  • @SocketSecurity ignore npm/@metamask/user-operation-controller@10.0.0

Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmire mcmire merged commit 3855767 into main May 31, 2024
146 of 147 checks passed
@mcmire mcmire deleted the revert-release-158 branch May 31, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants