feat: add getSelectedMultichainAccount and listMultichainAccounts #4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctedEvmAccountChange event
ccharly
reviewed
May 28, 2024
gantunesr
previously requested changes
May 29, 2024
gantunesr
reviewed
May 30, 2024
montelaidev
changed the title
ccharly
reviewed
May 31, 2024
montelaidev
force-pushed
the
fix/add-optional-args-to-accounts-controller
branch
from
8d35e9d
to
db08b3c
Compare
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
reviewed
May 31, 2024
ccharly
reviewed
May 31, 2024
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
approved these changes
May 31, 2024
mcmire
pushed a commit
that referenced
this pull request
May 31, 2024
) ## Explanation This pull request adds two new methods `getSelectedMultichainAccount`, `listMultichainAccounts` and `selectedEvmAccountChange` event. The optional arguments are to make the changes backwards compatible when used with evm specific controllers. ## References Related to: - [381](MetaMask/accounts-planning#381) - [419](MetaMask/accounts-planning#419) ## Changelog ### `@metamask/accounts-controller` - **<CHANGED>**: Adds two new methods `getSelectedMultichainAccount`, `listMultichainAccounts`, and `selectedEvmAccountChange` event ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This pull request adds two new methods
getSelectedMultichainAccount,listMultichainAccountsandselectedEvmAccountChangeevent. The optional arguments are to make the changes backwards compatible when used with evm specific controllers.References
Related to:
Changelog
@metamask/accounts-controllergetSelectedMultichainAccount,listMultichainAccounts, andselectedEvmAccountChangeeventChecklist