[token-detection-controller] Refactor detectTokens method
#3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorLift
force-pushed
the
240216-TokenDetectionController-detectTokens-refactor
branch
from
d4ff106
to
04634b4
Compare
…IdAndNetworkClientId`, `#getTokenListAndSlicesOfTokensToDetect`, `#addDetectedTokens` - Fixes #1614 - Maintains distinction between private class fields `#{chainId,selectedAddress,networkClientId}{,AgainstWhichToDetect}`, so that `detectTokens` method can be used independently of polling/passive detection (convert to static method?). Is this expected behavior?
MajorLift
force-pushed
the
240216-TokenDetectionController-detectTokens-refactor
branch
from
0189811
to
18fc929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Extracts three methods from
TokenDetectionController'sdetectTokensmethod:#getCorrectChainIdAndNetworkClientId#getTokenListAndSlicesOfTokensToDetect#addDetectedTokensMaintains distinction between private class fields
#{chainId,selectedAddress,networkClientId}{,AgainstWhichToDetect}, so thatdetectTokensmethod can be used independently of polling/passive detection.References
DetectTokensControllerupdates #3923TokenDetectionControllerup-to-date and release new version ofassets-controllers#3916Changelog
Checklist