Skip to content

chore(base-controller): Restore subscrbe property #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023
Merged

chore(base-controller): Restore subscrbe property #3698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/base-controller/src/BaseControllerV2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,17 @@ export class BaseController<

public readonly metadata: StateMetadata<ControllerState>;

/**
* The existence of the `subscribe` property is how the ComposableController used to detect
* whether a controller extends the old BaseController or the new one. We set it to `undefined` here to
* ensure the ComposableController never mistakes them for an older style controller.
*
* This property is no longer used, and will be removed in a future release.
*
* @deprecated This will be removed in a future release
*/
public readonly subscribe: undefined;

/**
* Creates a BaseController instance.
*
Expand Down