Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance transaction validation with standardized RPC errors #1690

Merged
merged 14 commits into from
Sep 27, 2023
Merged

Enhance transaction validation with standardized RPC errors #1690

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0036869
Refactor: Throw standardized RPC errors
vinistevam Sep 20, 2023
ff4441a
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 20, 2023
c989fdc
use @metamask/rpc-errors to standardize errors
vinistevam Sep 22, 2023
e39129b
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 22, 2023
566c941
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 22, 2023
1c7e573
Update packages/transaction-controller/package.json
vinistevam Sep 25, 2023
96720f3
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 25, 2023
ca1900f
update yarn.lock
vinistevam Sep 25, 2023
919d77b
revert rpc-errors due constraint incompatibility
vinistevam Sep 25, 2023
e35b7f3
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 25, 2023
094c55d
bump rpc-errors to v6
vinistevam Sep 25, 2023
dba7fa2
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 26, 2023
eeb053a
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 26, 2023
1593458
Merge branch 'main' into refactor/973-throw-rpc-error-validation
vinistevam Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into refactor/973-throw-rpc-error-validation
  • Loading branch information
@vinistevam
vinistevam committed Sep 22, 2023
commit e39129bcc957487f74b4549688cf83b40dd04be8
2 changes: 1 addition & 1 deletion packages/transaction-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@metamask/base-controller": "^3.2.1",
"@metamask/controller-utils": "^4.3.2",
"@metamask/eth-query": "^3.0.1",
"@metamask/network-controller": "^12.1.2",
"@metamask/network-controller": "^12.2.0",
"@metamask/rpc-errors": "^5.1.1",
legobeat marked this conversation as resolved.
Show resolved Hide resolved
"@metamask/utils": "^6.2.0",
"async-mutex": "^0.2.6",
Expand Down
40 changes: 38 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2244,6 +2244,42 @@ __metadata:
languageName: node
linkType: hard

"@metamask/rpc-methods@npm:^0.38.1-flask.1":
version: 0.38.1-flask.1
resolution: "@metamask/rpc-methods@npm:0.38.1-flask.1"
dependencies:
"@metamask/key-tree": ^9.0.0
"@metamask/permission-controller": ^4.1.0
"@metamask/snaps-ui": ^0.37.4-flask.1
"@metamask/snaps-utils": ^0.38.2-flask.1
"@metamask/types": ^1.1.0
"@metamask/utils": ^6.0.1
"@noble/hashes": ^1.3.1
eth-rpc-errors: ^4.0.3
superstruct: ^1.0.3
checksum: 49700a41a1340d36d484086a4f6ca0a3fea27f5f8119c9a9af9c2cd0aeecf7f603f6c89a2f122232c66a238e281023df82d4ad38c799da5a137ccfcf0bca6857
languageName: node
linkType: hard

"@metamask/rpc-methods@npm:^1.0.1":
version: 1.0.1
resolution: "@metamask/rpc-methods@npm:1.0.1"
dependencies:
"@metamask/browser-passworder": ^4.0.2
"@metamask/key-tree": ^7.1.1
"@metamask/permission-controller": ^4.0.0
"@metamask/snaps-ui": ^1.0.1
"@metamask/snaps-utils": ^1.0.1
"@metamask/types": ^1.1.0
"@metamask/utils": ^6.0.1
"@noble/hashes": ^1.1.3
eth-rpc-errors: ^4.0.2
nanoid: ^3.1.31
superstruct: ^1.0.3
checksum: 9d5c91f7af7c66b5f7afe23ce08a1d959bec1c7423063e955ae30ca41ed048e793a4e075b0fd23b9a8e54ff3a3fee018994e8d2fa494adebcc236f0bdd484340
languageName: node
linkType: hard

"@metamask/safe-event-emitter@npm:^2.0.0":
version: 2.0.0
resolution: "@metamask/safe-event-emitter@npm:2.0.0"
Expand Down Expand Up @@ -2523,8 +2559,8 @@ __metadata:
"@metamask/base-controller": ^3.2.1
"@metamask/controller-utils": ^4.3.2
"@metamask/eth-query": ^3.0.1
"@metamask/network-controller": ^12.1.2
"@metamask/rpc-errors": ^6.0.0
"@metamask/network-controller": ^12.2.0
"@metamask/rpc-errors": ^5.1.1
"@metamask/utils": ^6.2.0
"@types/jest": ^27.4.1
"@types/node": ^16.18.24
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.