Skip to content

Release 38.0.0 #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Release 38.0.0 #1035

merged 2 commits into from
Dec 20, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2022

Changelogs:

announcement-controller

[2.0.0]

Changed

  • BREAKING: Migrate to BaseControllerV2 (#959)
    • The announcement controller now extends BaseControllerV2 rather than BaseController, which includes the following changes:
      • The constructor now accepts a single "args" object rather than positional parameters.
      • A restricted controller messenger instance must be passed into the constructor.
      • The controller configuration has been replaced by an allAnnouncements constructor parameter.
      • The following properties previously inherited from BaseController are no longer present:
        • defaultConfig
        • defaultState
        • disabled
        • config
        • state
      • The following methods previously inherited from BaseController are no longer present:
        • configure
        • notify
        • subscribe
        • unsubscribe
        • update
      • The name property is now readonly.

assets-controllers

[3.0.1]

Changed

  • Export isTokenDetectionSupportedForNetwork function (#1034)
  • Update @metamask/contract-metadata from 1.35.0 to 2.1.0 (#1013)

Fixed

  • Fix token controller state updates (#1015)
    • Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.

@Gudahtt Gudahtt requested a review from a team as a code owner December 20, 2022 01:24
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 0939ae6 into main Dec 20, 2022
@Gudahtt Gudahtt deleted the release/38.0.0 branch December 20, 2022 18:03
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Changelogs:

# `announcement-controller`
## [2.0.0]
### Changed
- **BREAKING:** Migrate to BaseControllerV2
([#959](#959))
- The announcement controller now extends `BaseControllerV2` rather than
`BaseController`, which includes the following changes:
- The constructor now accepts a single "args" object rather than
positional parameters.
- A restricted controller messenger instance must be passed into the
constructor.
- The controller configuration has been replaced by an
`allAnnouncements` constructor parameter.
- The following properties previously inherited from `BaseController`
are no longer present:
      - `defaultConfig`
      - `defaultState`
      - `disabled`
      - `config`
      - `state`
- The following methods previously inherited from `BaseController` are
no longer present:
      - `configure`
      - `notify`
      - `subscribe`
      - `unsubscribe`
      - `update`
    - The `name` property is now readonly.

# `assets-controllers`
## [3.0.1]
### Changed
- Export `isTokenDetectionSupportedForNetwork` function
([#1034](#1034))
- Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0
([#1013](#1013))

### Fixed
- Fix token controller state updates
([#1015](#1015))
- Attempts to empty the list of "added", "ignored", or "detected" tokens
were not saved in state correctly, resulting in that operation being
undone after switching account or network.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Changelogs:

# `announcement-controller`
## [2.0.0]
### Changed
- **BREAKING:** Migrate to BaseControllerV2
([#959](#959))
- The announcement controller now extends `BaseControllerV2` rather than
`BaseController`, which includes the following changes:
- The constructor now accepts a single "args" object rather than
positional parameters.
- A restricted controller messenger instance must be passed into the
constructor.
- The controller configuration has been replaced by an
`allAnnouncements` constructor parameter.
- The following properties previously inherited from `BaseController`
are no longer present:
      - `defaultConfig`
      - `defaultState`
      - `disabled`
      - `config`
      - `state`
- The following methods previously inherited from `BaseController` are
no longer present:
      - `configure`
      - `notify`
      - `subscribe`
      - `unsubscribe`
      - `update`
    - The `name` property is now readonly.

# `assets-controllers`
## [3.0.1]
### Changed
- Export `isTokenDetectionSupportedForNetwork` function
([#1034](#1034))
- Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0
([#1013](#1013))

### Fixed
- Fix token controller state updates
([#1015](#1015))
- Attempts to empty the list of "added", "ignored", or "detected" tokens
were not saved in state correctly, resulting in that operation being
undone after switching account or network.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants