Skip to content

Use exports [Event | Action].type instead of strings when subscribing and calling #921

Closed
@BelfordZ

Description

@BelfordZ
    [Nit] What do you think about extracting this to a constant in NetworkController? This feels like the sort of knowledge that NetworkController should keep and expose to other places rather than copy around. Pro: more knowledge in one place. Con: Not sure if we've done that before for other controllers, so it would be a new pattern. Just a thought.

Originally posted by @mcmire in #903 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions