Skip to content

A GitHub release should not be created until after the release is approved by the NPM publishers team #5979

Open
@mcmire

Description

@mcmire

Currently, when a release PR is merged:

  • A Git tag is pushed
  • The GitHub release is created
  • npm publish is run in dry-run mode
  • The release workflow is paused while waiting for approval from NPM publishers
  • The release is approved
  • npm publish is run in non-dry-run mode

This means that a release is cancelled and needs to be re-created, the Git tag and GitHub release need to be removed first. We can avoid from needing to remember to do this if we change the workflow to:

  • npm publish is run in dry-run mode
  • The release workflow is paused while waiting for approval from NPM publishers
  • The release is approved
  • A Git tag is pushed
  • The GitHub release is created
  • npm publish is run in non-dry-run mode

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions