Provide extracted key with encryption #20
Conversation
darkwing
force-pushed
the
export-key
branch
from
70018e9 to
56fda48
Compare
darkwing
force-pushed
the
export-key
branch
3 times, most recently
from
7cf54c2 to
ec085f1
Compare
|
I see that you've committed the You can leave it committed in a separate branch for testing purposes |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
| * @param {R} dataObj - data to encrypt | ||
| * @returns {Promise<DetailedEncryptionResult>} object with vault and extractedKeyString | ||
| */ | ||
| async function encryptWithDetail<R>( |
There was a problem hiding this comment.
Rolling this back into encrypt might make mobile compatibility easier to manage. It'd be a breaking change, but we can easily update mobile to return { vault } rather than vault, and that's the only change we'd need. Whereas the alternative might be to severely complicate KeyringController to handle the two different types of encryptor libraries.
There was a problem hiding this comment.
On second thought, I am less sure of this suggestion now. Maybe we should figure out what makes sense on KeyringController first, then come back to this.
|
Superceded by #29 to avoid massive rebase. |
Prerequisite to MetaMask/KeyringController#152
Provides the key in string format so it may be used to unlock.