Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restricted text #202

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Update restricted text #202

merged 4 commits into from
Mar 22, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Mar 20, 2024

Partially closes MetaMask/metamask-docs#1195

Updates language for restricted methods to be less narrow. Follow up to @jiexi restricted methods PR

@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner March 20, 2024 18:34
openrpc.yaml Outdated Show resolved Hide resolved
openrpc.yaml Outdated Show resolved Hide resolved
openrpc.yaml Outdated Show resolved Hide resolved
@joaniefromtheblock
Copy link
Contributor Author

Thanks @alexandratran. Applied your suggestions.

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once final suggestions are integrated.

openrpc.yaml Outdated Show resolved Hide resolved
openrpc.yaml Outdated Show resolved Hide resolved
openrpc.yaml Outdated Show resolved Hide resolved
openrpc.yaml Outdated Show resolved Hide resolved
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock merged commit 8ad3625 into main Mar 22, 2024
7 checks passed
@joaniefromtheblock joaniefromtheblock deleted the update-restricted branch March 22, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update definition for "restricted" methods
3 participants