wallet_swapAsset v1 #201
Merged
wallet_swapAsset v1 #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
reviewed
Apr 25, 2024
tommasini
commented
Apr 25, 2024
…erty to optional and added to the description that defaults to 0
adonesky1
reviewed
May 24, 2024
adonesky1
reviewed
Jul 2, 2024
shanejonas
reviewed
Aug 2, 2024
adonesky1
reviewed
Nov 14, 2024
adonesky1
reviewed
Nov 14, 2024
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
adonesky1
approved these changes
Nov 14, 2024
alexandratran
added a commit
that referenced
this pull request
Feb 26, 2025
This reverts commit 7296916.
alexandratran
added a commit
that referenced
this pull request
Mar 1, 2025
alexandratran
pushed a commit
to alexandratran/api-specs
that referenced
this pull request
Mar 1, 2025
* wallet_swapAsset v1 * add patterns to the user address and tokens address * update error codes and remove referral code, also edit the value property to optional and added to the description that defaults to 0 * remove bad identation * update api spec with the new params accordingly and remove sendTo optional param * add schema for caip10 addresses and update address format on swap asset rpc method * update error code * added more error to the api spec regarding caip 10 addresses * the swap could not be completed as requested * add schema for Caip10Address * remove invalid params error from the api spec * change the code of swap not available on chain to 36000 * Update openrpc.yaml Co-authored-by: Alex Donesky <adonesky@gmail.com> * Update openrpc.yaml Co-authored-by: Alex Donesky <adonesky@gmail.com> --------- Co-authored-by: Alex Donesky <adonesky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This api-spec is a following work of the MIP of wallet_swapAsset: MetaMask/metamask-improvement-proposals#25