Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed revokePermissions result type to be null #176

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Changed revokePermissions result type to be null #176

merged 2 commits into from
Nov 29, 2023

Conversation

shanejonas
Copy link
Contributor

This PR Changes revokePermissions to return null in all cases. Goes along with this PR in extension: MetaMask/metamask-extension#22074

@shanejonas shanejonas requested a review from a team as a code owner November 29, 2023 15:17
shanejonas
shanejonas commented Nov 29, 2023
View reviewed changes
openrpc.json Outdated Show resolved Hide resolved
adonesky1
adonesky1 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanejonas shanejonas merged commit 4de4990 into main Nov 29, 2023
5 checks passed
@shanejonas shanejonas deleted the fix-revoke-return branch November 29, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanejonas @adonesky1