Resolve workspaces recursively for better Yarn 3 support #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
May 23, 2022
Comment on lines
+230
to
+238
| // If the error is not a file not found error, throw it | ||
| if (error.code !== 'ENOENT') { | ||
| console.error(`Failed to read changelog in "${projectRootDirectory}".`); | ||
| throw error; | ||
| } | ||
|
|
||
| return console.warn( | ||
| `Failed to read changelog in "${projectRootDirectory}".`, | ||
| ); |
Member
Author
There was a problem hiding this comment.
Since not all sub-workflow packages in snaps-skunkworks have a CHANGELOG.md, I changed this to ignore the package if the file doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to MetaMask/snaps#489.
With Yarn 3 it's possible to have a package in a workspace be a workspace as well ("sub-workspace"). Right now we only resolve packages in the root workspace, and packages in sub-workspaces are simply ignored. This PR changes the
getMetadataForAllPackagesto recursively resolve workspace packages.This is tested in the
snaps-skunkworksrepo.