-
-
Notifications
You must be signed in to change notification settings - Fork 9
chore(deps-dev): bump @metamask/create-release-branch from 3.1.0 to 4.1.4 #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps-dev): bump @metamask/create-release-branch from 3.1.0 to 4.1.4 #432
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
| "@lavamoat/allow-scripts": "^3.2.1", | ||
| "@lavamoat/preinstall-always-fail": "^2.1.0", | ||
| "@metamask/create-release-branch": "^3.1.0", | ||
| "@metamask/create-release-branch": "^4.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier peer dependency version mismatch breaks compatibility
High Severity
The updated @metamask/create-release-branch@^4.1.4 and its dependency @metamask/auto-changelog@^4.0.0 both require prettier>=3.0.0 as a peer dependency. However, the project has prettier: "^2.8.8" installed. This version mismatch will cause peer dependency warnings during installation and may result in runtime errors or incorrect behavior when using create-release-branch, since Prettier 3.x has different APIs and formatting behavior than Prettier 2.x.
Additional Locations (1)
6575eb2 to
7bb7840
Compare
69ff43b to
15b7000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| yargs: "npm:^17.7.1" | ||
| peerDependencies: | ||
| prettier: ^2 | ||
| prettier: ">=3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer dependency mismatch: Prettier 2 incompatible with v4
High Severity
The upgraded @metamask/create-release-branch@^4.1.4 declares a peer dependency of prettier: ">=3.0.0", and its transitive dependency @metamask/auto-changelog@^4.0.0 also requires prettier: ">=3.0.0". However, the project has prettier: "^2.8.8" installed. This peer dependency mismatch will cause the release tooling to fail at runtime when it tries to use Prettier functionality, since the installed version doesn't meet the minimum required version.
Additional Locations (2)
Bumps [@metamask/create-release-branch](https://github.com/MetaMask/create-release-branch) from 3.1.0 to 4.1.4. - [Release notes](https://github.com/MetaMask/create-release-branch/releases) - [Changelog](https://github.com/MetaMask/create-release-branch/blob/main/CHANGELOG.md) - [Commits](MetaMask/create-release-branch@v3.1.0...v4.1.4) --- updated-dependencies: - dependency-name: "@metamask/create-release-branch" dependency-version: 4.1.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
15b7000 to
96feb46
Compare


Bumps @metamask/create-release-branch from 3.1.0 to 4.1.4.
Release notes
Sourced from
@metamask/create-release-branch's releases.Changelog
Sourced from
@metamask/create-release-branch's changelog.... (truncated)
Commits
bde34744.1.4 (#196)3855be0Detect direct dependents missing from release (#193)aaf2c3bImprove UI/copy for per-package error messages (#192)9c6c63cFix ESLint config (#191)7d5f2c8Add preview builds (#187)b4d6fffchore: Update codeowners to@MetaMask/core-platform(#188)7ba6cd24.1.3 (#182)814254bFix repo links in updated changelogs to matchauto-changelog(#165)8e225134.1.2 (#180)748288edocs: format CHANGELOG.md with prettier (#181)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Medium Risk
Moderate risk because this upgrades a release automation tool across a major version and its new peer dependency requirement (
prettier >=3) may conflict with the repo’s currentprettier@^2.8.8, potentially breaking release workflows/CI installs.Overview
Updates the dev dependency
@metamask/create-release-branchfrom^3.1.0to^4.1.4.The lockfile is refreshed to pull in
create-release-branchv4’s updated dependency tree (including newer@metamask/auto-changelogand new transitive deps likeexpress/open) and its updated peer dependency expectations (notablyprettier >=3).Written by Cursor Bugbot for commit 96feb46. This will update automatically on new commits. Configure here.