Adds Contour Frequency by Altitude Diagrams (CFAD) calculation code #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
daflack
force-pushed
the
1010_CFADs
branch
6 times, most recently
from
0932ff7 to
0083d51
Compare
daflack
force-pushed
the
1010_CFADs
branch
2 times, most recently
from
ca23bf8 to
db52372
Compare
daflack
force-pushed
the
1010_CFADs
branch
2 times, most recently
from
478851a to
d3c5f25
Compare
Contributor
Author
|
Will require a scientific review and a technical review. Notes for reviewers: pending the re-write of plot.py it was viewed as sensible to not include the plotting of this function. Instead please just focus on whether it would create a CFAD or not. |
daflack
changed the title
daflack
requested review from
BernardClaxton,
JMEdwardsXtr,
cehalliwell,
jfrost-mo and
jwarner8
jfrost-mo
previously requested changes
Aug 11, 2025
Member
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
The main thing is to check that the cube name is being set correctly. Otherwise its largely nits from a technical point of view.
It would be good to also have a science review, as I'm not familiar with CFADs.
jfrost-mo
reviewed
Aug 11, 2025
Member
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
We should probably also remove the standard name if we are renaming. Otherwise looks good technically.
jfrost-mo
reviewed
Aug 12, 2025
Member
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
Looks good. Now over to the scientific review.
daflack
force-pushed
the
1010_CFADs
branch
2 times, most recently
from
4073fd6 to
ca47404
Compare
daflack
force-pushed
the
1010_CFADs
branch
2 times, most recently
from
ebd84ed to
eec0f3b
Compare
daflack
force-pushed
the
1010_CFADs
branch
2 times, most recently
from
533c8ed to
e9ed89e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Contour Frequency by Altitude (CFAD) into CSET.
Fixes #1010
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.