Add test for Python samples. #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting Triangulation_v3.dox.py as outdated: V2 file is not working with new meshlib bindings.
Deleting Triangulation_v3.dox.py as outdated: V2 file is not working with new meshlib bindings.
Grantim
reviewed
Nov 9, 2024
Comment on lines
27
to
29
| params = mm.OffsetParameters() | ||
| params.voxelSize = 0.1 | ||
| triangulated_pc = mm.offsetMesh(triangulated_pc, 0.0, params=params) |
There was a problem hiding this comment.
actually in V2 it should work with default parameters too
| @@ -26,6 +26,8 @@ | |||
| triangulated_pc = mm.triangulatePointCloud(pc) | |||
|
|
|||
| # Fix possible issues | |||
| triangulated_pc = mm.offsetMesh(triangulated_pc, 0.0) | |||
| offsetParams = mm.OffsetParameters() | |||
| offsetParams.voxelSize = 0.1 | |||
There was a problem hiding this comment.
please use
Suggested change
| offsetParams.voxelSize = 0.1 | |
| offsetParams.voxelSize = mm.suggestVoxelSize( triangulated_pc, 5e6 ) |
# Conflicts: # examples/python-examples/Examples.dox # examples/python-examples/Triangulation_v3.dox.py
Grantim
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting Triangulation_v3.dox.py as outdated: V2 file is not working with new meshlib bindings.