-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add missing hardware models with actual device images #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…holder SVGs Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
|
@copilot search for the missing images, start with the meshtastic org and look at repos most recently updated: https://github.com/meshtastic |
I found the hardware images in the meshtastic organization! Here's what I discovered: Found images for our new hardware models:
Most are in WebP format. I've prepared a script to download and convert them to replace the placeholder SVGs. The actual device photos will provide much better visual identification than the gray placeholders currently in place. Next step: Download the actual hardware images and update the placeholder files. |
…meshtastic repo Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
|
@copilot download the images and put them in this PR. We might want to investigate a submodule if they're all in that repository, look into that, it might be the best option for longevity |
Co-authored-by: daviesgeek <2348508+daviesgeek@users.noreply.github.com>
The images are already in the PR (commit 0cfc2a8)! I've also investigated the submodule option. Decision: Use downloaded images (current approach) The submodule would add unnecessary complexity:
I've documented the image update process in the README (commit d233b28) for when new hardware is released. The approach is efficient and maintainable for this use case. |
Adds 18 missing hardware models from Meshtastic's device_hardware.json and implements multi-format image support (SVG/PNG/WebP) per issue #156. Includes actual device images downloaded from the official Meshtastic documentation repository.
Changes
Enum Updates
meshtastic_support.py) and TypeScript (frontend/src/types/index.ts) enumsNRF52840DK→T_ECHO_PLUS(33) andRAK2560→WISMESH_HUB(22) to match upstream protocolImage Handling
HardwareImg.tsxto detect format by extension and conditionally apply dark mode filters (PNG/WebP only, not SVG)HARDWARE_PHOTOSmappings in both Python and TypeScriptfrontend/public/images/hardware/andpublic/images/hardware/(React + Jinja2 template support)Documentation
Example
Hardware Images Included
Actual device photos from https://github.com/meshtastic/meshtastic/tree/master/static/img/hardware:
New hardware models include: HELTEC_VISION_MASTER series, SENSECAP_INDICATOR, TRACKER_T1000_E, SEEED_XIAO_S3, WISMESH_TAP/TAG, THINKNODE_M1/M2/M5, MUZI_BASE, HELTEC_MESH_POCKET, SEEED_SOLAR_NODE.
Design Decision: Downloaded Images vs Git Submodule
After evaluation, we chose the downloaded images approach over using a git submodule for the meshtastic/meshtastic repository because:
The README includes documentation on how to update images when new hardware models are released.
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.