Develop #558
Develop #558
Conversation
…mentation - Updated the version of PraisonAI from 2.2.21 to 2.2.22 in all relevant Dockerfiles. - Adjusted README and local development documentation to reflect the new version. - Ensured consistency in versioning across all instances where PraisonAI is referenced.
|
Caution Review failedThe pull request is closed. WalkthroughThis update increments the PraisonAI package version from 2.2.21 to 2.2.22 across all Dockerfiles, deployment scripts, and documentation. It also adds documentation and an example for integrating Playwright MCP with PraisonAI agents. The praisonaiagents package version is incremented, and related documentation navigation is updated. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PraisonAI Agent
participant Playwright MCP Server
User->>PraisonAI Agent: Start agent with web search task
PraisonAI Agent->>Playwright MCP Server: Connect via MCP endpoint (http://localhost:8931/sse)
PraisonAI Agent->>Playwright MCP Server: Send browser automation/search commands
Playwright MCP Server-->>PraisonAI Agent: Return results
PraisonAI Agent-->>User: Provide search findings
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (16)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @MervinPraison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a summary of this pull request. Based on the generic title "Develop" and the empty description, the primary intent appears to be a general update and synchronization of the codebase, specifically focusing on dependency version bumps and the introduction of new documentation and examples related to Playwright integration with the Model Context Protocol (MCP). The changes primarily involve updating the required PraisonAI and praisonaiagents package versions across various configurations and adding new files for Playwright MCP support.
Highlights
- Dependency Version Updates: The pull request updates the required version of the
PraisonAIpackage from>=2.2.21to>=2.2.22and thepraisonaiagentspackage from0.0.92to0.0.93across multiple Dockerfiles, documentation examples, and project configuration files (pyproject.toml,uv.lock, Homebrew formula). - Playwright MCP Integration Documentation and Example: New documentation (
docs/mcp/playwright.mdx) and a Python example (examples/python/mcp/playwright-mcp.py) have been added to demonstrate how to use Playwright with the Model Context Protocol (MCP) within the PraisonAI framework, enabling agents to interact with web browsers.
Changelog
Click here to see the changelog
- docker/Dockerfile
- Updated PraisonAI dependency version to
>=2.2.22.
- Updated PraisonAI dependency version to
- docker/Dockerfile.chat
- Updated PraisonAI dependency version to
>=2.2.22.
- Updated PraisonAI dependency version to
- docker/Dockerfile.dev
- Updated PraisonAI dependency version to
>=2.2.22.
- Updated PraisonAI dependency version to
- docker/Dockerfile.ui
- Updated PraisonAI dependency version to
>=2.2.22.
- Updated PraisonAI dependency version to
- docker/README.md
- Updated mentioned PraisonAI version in 'Package Versions' section to
>=2.2.22. - Updated specific version pin example in 'Version Pinning' section to
==2.2.22.
- Updated mentioned PraisonAI version in 'Package Versions' section to
- docs/api/praisonai/deploy.html
- Updated hardcoded PraisonAI version in Dockerfile example to
==2.2.22.
- Updated hardcoded PraisonAI version in Dockerfile example to
- docs/developers/local-development.mdx
- Updated hardcoded PraisonAI version in Dockerfile example to
==2.2.22.
- Updated hardcoded PraisonAI version in Dockerfile example to
- docs/mcp/playwright.mdx
- Added new documentation file detailing Playwright MCP setup and usage with PraisonAI.
- docs/mint.json
- Added 'mcp/playwright' to the documentation navigation structure.
- docs/ui/chat.mdx
- Updated hardcoded PraisonAI version in Dockerfile example to
==2.2.22.
- Updated hardcoded PraisonAI version in Dockerfile example to
- docs/ui/code.mdx
- Updated hardcoded PraisonAI version in Dockerfile example to
==2.2.22.
- Updated hardcoded PraisonAI version in Dockerfile example to
- examples/python/mcp/playwright-mcp.py
- Added a new Python example demonstrating Playwright MCP usage with
praisonaiagents.
- Added a new Python example demonstrating Playwright MCP usage with
- src/praisonai-agents/pyproject.toml
- Updated
praisonaiagentspackage version to0.0.93.
- Updated
- src/praisonai-agents/uv.lock
- Updated
praisonaiagentsversion in the lock file to0.0.93.
- Updated
- src/praisonai/praisonai.rb
- Updated Homebrew formula URL and SHA256 to reference PraisonAI
v2.2.22.
- Updated Homebrew formula URL and SHA256 to reference PraisonAI
- src/praisonai/praisonai/deploy.py
- Updated hardcoded PraisonAI version in
create_dockerfilefunction to==2.2.22.
- Updated hardcoded PraisonAI version in
- src/praisonai/pyproject.toml
- Updated PraisonAI package version to
2.2.22in project metadata and poetry configuration.
- Updated PraisonAI package version to
- src/praisonai/uv.lock
- Updated praisonai version in the lock file to
2.2.22.
- Updated praisonai version in the lock file to
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Versions tick and climb,
New docs arrive in time,
Agents browse the web,
No longer in their bed,
Code evolves, a steady rhyme.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for praisonai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request primarily handles version bumps for praisonai (to v2.2.22) and praisonaiagents (to v0.0.93) across various configuration files, Dockerfiles, and documentation. A key addition is the new documentation and example for using Playwright with the Model Context Protocol (MCP), which is a welcome enhancement.
Most changes are straightforward and correctly implemented. However, there's a significant concern regarding the SHA256 checksum calculation in the Homebrew formula, which needs to be addressed.
Summary of Findings
- Homebrew Formula SHA256 Calculation: A high-severity issue was found in
src/praisonai/praisonai.rbwhere the SHA256 checksum for the Homebrew formula is calculated dynamically using a shell command. This practice compromises the integrity verification purpose of the checksum. It should be replaced with a static, pre-calculated hash. - Version Updates and Documentation: The version bumps for
praisonaiandpraisonaiagentsare consistently applied across Dockerfiles, package metadata, and documentation examples. The new documentation for Playwright MCP (docs/mcp/playwright.mdx) and its corresponding Python example (examples/python/mcp/playwright-mcp.py) are clear, well-structured, and valuable additions. - Other Changes: All other changes, primarily version string updates in various files, appear correct and consistent with the main version bumps. No other medium, high, or critical issues were identified in the diff.
Merge Readiness
The pull request introduces necessary version updates and valuable new documentation for Playwright MCP. However, due to the high severity issue identified with the Homebrew formula's SHA256 calculation method, I recommend that this issue be addressed before merging to ensure security and adherence to Homebrew best practices. I am not authorized to approve pull requests; this feedback is for your consideration and further action by the maintainers.
| url "https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.21.tar.gz" | ||
| sha256 `curl -sL https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.21.tar.gz | shasum -a 256`.split.first | ||
| url "https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.22.tar.gz" | ||
| sha256 `curl -sL https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.22.tar.gz | shasum -a 256`.split.first |
There was a problem hiding this comment.
The current method of calculating the sha256 checksum using a shell command (via backticks) at runtime is a concern. In Homebrew formulas, the sha256 is intended to be a static, pre-calculated hash of the release artifact. This ensures that Homebrew can verify the integrity and authenticity of the downloaded file against a known, trusted value.
Dynamically calculating the hash from the downloaded file itself, as done here, bypasses this crucial security check. If the artifact at the URL were compromised, this method would simply calculate the hash of the compromised file, and the verification would misleadingly pass.
Could you please update this to use a hardcoded SHA256 hash for the v2.2.22.tar.gz release artifact? You can obtain this by downloading the tarball and then running shasum -a 256 <filename>.tar.gz.
sha256 "PUT_PRECALCULATED_SHA256_HASH_FOR_v2.2.22_HERE" # e.g., shasum -a 256 praisonai-2.2.22.tar.gz
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores