-
-
Notifications
You must be signed in to change notification settings - Fork 744
Update version numbers and dependencies to 2.2.2 and 0.0.87 across pr… #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oject files - Incremented PraisonAI version from 2.2.1 to 2.2.2 in pyproject.toml, uv.lock, Dockerfiles, and documentation. - Updated praisonaiagents version from 0.0.85 to 0.0.87 in relevant files. - Adjusted installation commands in GitHub Actions workflow to use 'uv' for dependency management. - Enhanced test scripts to return meaningful results for better assertion checks.
✅ Deploy Preview for praisonai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. WalkthroughThis update increments the versions of the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant uv
participant Python Unittest
Developer->>GitHub Actions: Push code / open PR
GitHub Actions->>uv: Install dependencies (with extras)
GitHub Actions->>uv: Install duckduckgo_search
GitHub Actions->>uv: Run unittests
uv->>Python Unittest: Execute tests
Python Unittest-->>uv: Return results
uv-->>GitHub Actions: Test results
Possibly related PRs
Suggested labels
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (17)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MervinPraison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a summary of this pull request. This PR primarily focuses on updating version numbers for the praisonai and praisonaiagents packages across the project. It bumps praisonai from 2.2.1 to 2.2.2 and praisonaiagents from 0.0.85 to 0.0.87. These version updates are reflected in the main pyproject.toml, the uv.lock files, various Dockerfiles, and documentation examples. Additionally, the PR includes minor code changes in the praisonaiagents package related to context handling and significant updates to the test examples and test suite to improve the reliability and clarity of test results.
Highlights
- Version Updates: The core change involves updating the project's main version to
2.2.2and thepraisonaiagentsdependency version to0.0.87inpyproject.tomlanduv.lockfiles. - Dockerfile and Documentation Sync: The updated
praisonaiversion (2.2.2) is propagated to all relevant Dockerfiles (docker/Dockerfile,docker/Dockerfile.chat,docker/Dockerfile.dev,docker/Dockerfile.ui) and documentation snippets (docs/api/praisonai/deploy.html,docs/developers/local-development.mdx,docs/ui/chat.mdx,docs/ui/code.mdx,praisonai/deploy.py) to ensure consistency. - Improved Test Examples and Assertions: The example scripts (
tests/advanced_example.py,tests/auto_example.py,tests/basic_example.py) are modified to correctly locate configuration files and return more explicit success indicators or results. The corresponding test suite (tests/test.py) is updated to assert against these new return values for better test reliability. - Minor Agent Code Refinement: A small code change in
src/praisonai-agents/praisonaiagents/agents/agents.pyintroduces a variable for the context separator, improving code readability slightly.
Changelog
Click here to see the changelog
- docker/Dockerfile
- Updated
praisonaiversion from2.2.1to2.2.2inRUN pip installcommand (line 4).
- Updated
- docker/Dockerfile.chat
- Updated
praisonaiversion from2.2.1to2.2.2inRUN pip installcommand (line 16).
- Updated
- docker/Dockerfile.dev
- Updated
praisonaiversion from2.2.1to2.2.2inRUN pip installcommand (line 18).
- Updated
- docker/Dockerfile.ui
- Updated
praisonaiversion from2.2.1to2.2.2inRUN pip installcommand (line 16).
- Updated
- docs/api/praisonai/deploy.html
- Updated
praisonaiversion from2.2.1to2.2.2in the embedded Dockerfile string (line 113).
- Updated
- docs/developers/local-development.mdx
- Updated
praisonaiversion from2.2.1to2.2.2in the Dockerfile example snippet (line 30).
- Updated
- docs/ui/chat.mdx
- Updated
praisonaiversion from2.2.1to2.2.2in the Dockerfile example snippet (line 158).
- Updated
- docs/ui/code.mdx
- Updated
praisonaiversion from2.2.1to2.2.2in the Dockerfile example snippet (line 211).
- Updated
- praisonai/deploy.py
- Updated
praisonaiversion from2.2.1to2.2.2in the generated Dockerfile string (line 59).
- Updated
- pyproject.toml
- Updated project version from
2.2.1to2.2.2(line 3). - Updated
praisonaiagentsdependency from>=0.0.85to>=0.0.87(line 15). - Updated poetry tool version from
2.2.1to2.2.2(line 92). - Updated poetry tool
praisonaiagentsdependency from>=0.0.85to>=0.0.87(line 110).
- Updated project version from
- src/praisonai-agents/praisonaiagents/agents/agents.py
- Introduced
context_separator = '\n\n'variable and used it to join contexts inaexecute_task(lines 322, 326). - Introduced
context_separator = '\n\n'variable and used it to join contexts inexecute_task(lines 622, 626).
- Introduced
- src/praisonai-agents/pyproject.toml
- Updated project version from
0.0.85to0.0.87(line 7).
- Updated project version from
- src/praisonai-agents/uv.lock
- Updated
praisonaiagentspackage version from0.0.85to0.0.87(line 1460). - Updated sdist and wheel URLs and hashes for
praisonaiagents(lines 3824, 3826).
- Updated
- tests/advanced_example.py
- Added
osimport (line 2). - Added logic to determine
agents.yamlpath relative to the script (lines 5-7). - Updated
PraisonAIinitialization to use the relative path (line 10). - Modified function to return a meaningful success string or the actual result for testing (lines 14-21).
- Added
- tests/auto_example.py
- Added
osimport (line 2). - Modified function to return a meaningful success string or the actual result for testing (lines 10-17).
- Added
- tests/basic_example.py
- Added
osimport (line 2). - Added logic to determine
agents.yamlpath relative to the script (lines 5-7). - Updated
PraisonAIinitialization to use the relative path (line 9). - Modified function to return a meaningful success string or the actual result for testing (lines 10-17).
- Added
- tests/test.py
- Updated assertions in
test_basic_exampleto check for success string or non-empty result (lines 61-66). - Updated assertions in
test_advanced_exampleto check for success string or non-empty result (lines 74-79). - Updated assertions in
test_auto_exampleto check for success string or non-empty result (lines 88-93).
- Updated assertions in
- uv.lock
- Updated
praisonaipackage version from2.2.1to2.2.2(line 3617). - Updated
praisonaiagentsdependency version from>=0.0.85to>=0.0.87(line 3759). - Updated
praisonaiagentspackage version from0.0.85to0.0.87(line 3816). - Updated sdist and wheel URLs and hashes for
praisonaiagents(lines 3824, 3826).
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Versions climb and grow,
Dependencies now flow,
Tests check the way.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively updates the version numbers for PraisonAI to 2.2.2 and praisonaiagents to 0.0.87 across various project files, including pyproject.toml, uv.lock, Dockerfiles, and documentation.
The enhancements to the test scripts are particularly commendable. Using os.path.join(os.path.dirname(os.path.abspath(__file__)), ...) for locating agents.yaml makes the tests more robust and independent of the execution directory. The updated assertions in tests/test.py are more specific and provide better feedback on test failures, which is a significant improvement.
The minor refactoring in src/praisonai-agents/praisonaiagents/agents/agents.py to use a context_separator variable is a nice touch for readability and maintainability.
Overall, the changes are well-executed and contribute positively to the project's quality and reliability. No major issues were found.
Summary of Findings
- Consistent Version Updates: Version numbers for PraisonAI (to 2.2.2) and praisonaiagents (to 0.0.87) were consistently updated across all relevant project configuration files, Dockerfiles, and documentation snippets.
- Test Script Robustness: Test scripts (
tests/advanced_example.py,tests/basic_example.py) were improved by dynamically determining the path toagents.yamlrelative to the test file location. This makes the tests more portable and less prone to errors based on the current working directory. - Enhanced Test Assertions: Assertions in
tests/test.pywere significantly improved to check for more specific outcomes (e.g., presence of success messages or non-empty output) rather than just non-None results, making the tests more meaningful and reliable. - Improved Test Return Values: Example functions in
tests/advanced_example.py,tests/auto_example.py, andtests/basic_example.pywere modified to return explicit success messages when their core operations complete without returning a specific data result. This aids in creating clearer and more effective test assertions. - Code Readability in Agent Logic: In
src/praisonai-agents/praisonaiagents/agents/agents.py, the hardcoded context separator\n\nwas refactored into a named variablecontext_separator, slightly improving code readability and maintainability within theaexecute_taskandexecute_taskmethods.
Merge Readiness
The pull request appears to be in good shape. The version updates are applied consistently, and the test enhancements significantly improve the robustness and clarity of the test suite. I have not identified any critical or high-severity issues in the provided diffs. While I cannot approve the pull request myself, these changes look ready for merging after any standard CI checks pass and other reviewers concur.
…oject files
Summary by CodeRabbit
Chores
Bug Fixes
Tests
Refactor