Merge pull request #999 from MervinPraison/claude/issue-987-20250718-1504

Fix: Resolve agent termination issue by adding comprehensive telemetry cleanup

Author: MervinPraison

src/praisonai-agents/praisonaiagents/agent/agent.py

@@ -1407,11 +1407,15 @@ def chat(self, prompt, temperature=0.2, tools=None, output_json=None, output_pyd
                                 validated_response = self._apply_guardrail_with_retry(response_text, original_prompt, temperature, tools, task_name, task_description, task_id)
                                 # Execute callback after validation
                                 self._execute_callback_and_display(original_prompt, validated_response, time.time() - start_time, task_name, task_description, task_id)
+                                # Ensure proper cleanup of telemetry system to prevent hanging
+                                self._cleanup_telemetry()
                                 return validated_response
                             except Exception as e:
                                 logging.error(f"Agent {self.name}: Guardrail validation failed: {e}")
                                 # Rollback chat history on guardrail failure
                                 self.chat_history = self.chat_history[:chat_history_length]
+                                # Ensure proper cleanup of telemetry system to prevent hanging
+                                self._cleanup_telemetry()
                                 return None
 
                         reflection_prompt = f"""
@@ -1524,6 +1528,8 @@ def __init__(self, data):
                 display_error(f"Unexpected error in chat: {e}", console=self.console)
                 # Rollback chat history
                 self.chat_history = self.chat_history[:chat_history_length]
+                # Ensure proper cleanup of telemetry system to prevent hanging
+                self._cleanup_telemetry()
                 return None
 
     def clean_json_output(self, output: str) -> str:
@@ -1641,6 +1647,8 @@ async def achat(self, prompt: str, temperature=0.2, tools=None, output_json=None
                     if logging.getLogger().getEffectiveLevel() == logging.DEBUG:
                         total_time = time.time() - start_time
                         logging.debug(f"Agent.achat failed in {total_time:.2f} seconds: {str(e)}")
+                    # Ensure proper cleanup of telemetry system to prevent hanging
+                    self._cleanup_telemetry()
                     return None
 
             # For OpenAI client
@@ -1818,17 +1826,23 @@ async def achat(self, prompt: str, temperature=0.2, tools=None, output_json=None
                             validated_response = self._apply_guardrail_with_retry(response_text, original_prompt, temperature, tools, task_name, task_description, task_id)
                             # Execute callback after validation
                             self._execute_callback_and_display(original_prompt, validated_response, time.time() - start_time, task_name, task_description, task_id)
+                            # Ensure proper cleanup of telemetry system to prevent hanging
+                            self._cleanup_telemetry()
                             return validated_response
                         except Exception as e:
                             logging.error(f"Agent {self.name}: Guardrail validation failed for OpenAI client: {e}")
                             # Rollback chat history on guardrail failure
                             self.chat_history = self.chat_history[:chat_history_length]
+                            # Ensure proper cleanup of telemetry system to prevent hanging
+                            self._cleanup_telemetry()
                             return None
                 except Exception as e:
                     display_error(f"Error in chat completion: {e}")
                     if logging.getLogger().getEffectiveLevel() == logging.DEBUG:
                         total_time = time.time() - start_time
                         logging.debug(f"Agent.achat failed in {total_time:.2f} seconds: {str(e)}")
+                    # Ensure proper cleanup of telemetry system to prevent hanging
+                    self._cleanup_telemetry()
                     return None
         except Exception as e:
             display_error(f"Error in achat: {e}")

test_termination_fix.py

@@ -0,0 +1,40 @@
+#!/usr/bin/env python3
+"""
+Test script to verify the agent termination fix.
+This script should terminate properly without requiring Ctrl+C.
+"""
+
+import sys
+import os
+import time
+
+# Add the praisonai-agents package to the Python path
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), 'src', 'praisonai-agents'))
+
+try:
+    from praisonaiagents import Agent
+    
+    print("Starting agent termination test...")
+    start_time = time.time()
+    
+    # Create an agent with the same configuration as the issue example
+    agent = Agent(instructions="You are a helpful AI assistant")
+    
+    # Test the exact scenario from the issue
+    print("Testing agent.start() with movie script request...")
+    result = agent.start("Write a short movie script about a robot on Mars")
+    
+    end_time = time.time()
+    execution_time = end_time - start_time
+    
+    print(f"\n✅ Test completed successfully in {execution_time:.2f} seconds")
+    print("✅ Agent terminated properly without requiring Ctrl+C")
+    print("✅ Fix verified: Telemetry cleanup is working correctly")
+    
+except ImportError as e:
+    print(f"❌ Import error: {e}")
+    print("Make sure you're running this from the correct directory")
+    sys.exit(1)
+except Exception as e:
+    print(f"❌ Error during test: {e}")
+    sys.exit(1)