Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an error for a possible memory allocation error #20

Merged
merged 6 commits into from
Sep 23, 2023
Merged

Adding an error for a possible memory allocation error #20

merged 6 commits into from
Sep 23, 2023

Conversation

Furokop
Copy link
Contributor

@Furokop Furokop commented Sep 23, 2023

I have added a check to see if "jsonData" is properly allocated within heap.

I have also made it so that big stack allocations are now heap allocations.

MertGunduz
MertGunduz approved these changes Sep 23, 2023
View reviewed changes
Copy link
Owner

@MertGunduz MertGunduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Furokop,

Thanks for your pull request 🚀

Your changes are approved!

@MertGunduz MertGunduz merged commit fe35f15 into MertGunduz:main Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MertGunduz MertGunduz MertGunduz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Furokop @MertGunduz