Groq Provider + Smoke test + update sdks #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Deployed to the echo-pr-582 environment in echo
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| expect(streamed).not.toBe(''); | ||
| } catch (err) { | ||
| const details = getApiErrorDetails(err); | ||
| throw new Error(`[generateText] Groq ${model_id} failed: ${details}`); |
Contributor
There was a problem hiding this comment.
The error message in the streamText test incorrectly identifies itself as a generateText test, which could cause confusion when debugging test failures.
View Details
📝 Patch Details
diff --git a/packages/tests/provider-smoke/gemini-stream-text.test.ts b/packages/tests/provider-smoke/gemini-stream-text.test.ts
index 086995ce..0fa669d5 100644
--- a/packages/tests/provider-smoke/gemini-stream-text.test.ts
+++ b/packages/tests/provider-smoke/gemini-stream-text.test.ts
@@ -38,7 +38,7 @@ describe.concurrent('Gemini streamText per model', () => {
expect(streamed).not.toBe('');
} catch (err) {
const details = getApiErrorDetails(err);
- throw new Error(`[generateText] Gemini ${model_id} failed: ${details}`);
+ throw new Error(`[streamText] Gemini ${model_id} failed: ${details}`);
}
});
}
diff --git a/packages/tests/provider-smoke/groq-stream-text.test.ts b/packages/tests/provider-smoke/groq-stream-text.test.ts
index 05e663c1..d3a86d2d 100644
--- a/packages/tests/provider-smoke/groq-stream-text.test.ts
+++ b/packages/tests/provider-smoke/groq-stream-text.test.ts
@@ -35,7 +35,7 @@ describe.concurrent('Groq streamText per model', () => {
expect(streamed).not.toBe('');
} catch (err) {
const details = getApiErrorDetails(err);
- throw new Error(`[generateText] Groq ${model_id} failed: ${details}`);
+ throw new Error(`[streamText] Groq ${model_id} failed: ${details}`);
}
});
}
Analysis
Incorrect error message labels in streamText tests
What fails: groq-stream-text.test.ts and gemini-stream-text.test.ts use [generateText] in error messages instead of [streamText], causing confusion when debugging test failures
How to reproduce:
- Run a streamText test that fails (e.g., invalid API key)
- Error message incorrectly shows
[generateText] Groq model failedinstead of[streamText] Groq model failed
Result: Misleading error messages that misidentify the failing operation as generateText when it's actually streamText
Expected: Error messages should use [streamText] to match the actual test purpose, consistent with anthropic-stream-text.test.ts, openai-stream-text.test.ts, and openrouter-stream-text.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.