Disallow non-ASCII in email domain #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19166872701Details
💛 - Coveralls |
varmar05
reviewed
Nov 5, 2025
varmar05
reviewed
Nov 5, 2025
varmar05
reviewed
Nov 5, 2025
varmar05
approved these changes
Nov 7, 2025
Collaborator
|
Let's keep this open until new v2 push (2025.8.1) is on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/MerginMaps/server-private/issues/3111
Non-ASCII characters in email domain might break email service provide API
We use close approximation of the regex provided by Brevo (https://github.com/MerginMaps/server-private/issues/3111#issuecomment-3491438139)