Skip to content

Fix 180 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Fix 180 #187

merged 13 commits into from
Oct 13, 2023

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Oct 12, 2023

Fixes #180

Issue deprecation warnings for mc.create_project() and mc.clone_project(() if namespace parameter is specified. Still supports the old syntax for backwards compatability.

mergin clone will also print statements if CLONED_PROJECT_NAMESPACE parameter is used or if CLONED_PROJECT_NAME is not a full path that includes workspace name.

@JanCaha JanCaha requested a review from wonder-sk October 12, 2023 08:45
Copy link
Contributor

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "create" command in CLI should also migrate to the new create_project() API calls

@JanCaha
Copy link
Contributor Author

JanCaha commented Oct 13, 2023

@wonder-sk This should be ready with all the changes suggested above.

The only thing I am slightly unsure is in mergin create there are few lines verifying the input project name. Should those stay there or should this be handled in the client? It should be able to just handle it now quite fine a this verification does need to be there. https://github.com/MerginMaps/mergin-py-client/blob/5cc26f28eed3f37086ab015894df8ddbaeb82e9b/mergin/cli.py#L203-L213

@wonder-sk
Copy link
Contributor

@JanCaha yeah let's delete that part of the code in CLI...

@wonder-sk wonder-sk merged commit 7ff8768 into master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix awkward create_project() and clone_project() syntax
2 participants