Add app delivery github action #4232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19702399438Details
💛 - Coveralls |
Contributor
gabriel-bolbotina
left a comment
gabriel-bolbotina
left a comment
There was a problem hiding this comment.
Looks good to me ✅
Please check the CMakeLists.txt file
CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.22) | |||
| cmake_minimum_required(VERSION 3.22) | |||
Contributor
There was a problem hiding this comment.
Delete added space
Contributor
Author
There was a problem hiding this comment.
oh sure, just needed that to trigger the workflows
Contributor
Author
|
I'll keep this open until friday, when I'll have time to get back to it |
gabriel-bolbotina
approved these changes
Nov 26, 2025
Contributor
gabriel-bolbotina
left a comment
gabriel-bolbotina
left a comment
There was a problem hiding this comment.
@tomasMizera now's your turn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new github action to collect all built artifacts and then comment links to them under the PR. This should mainly help our testing team.
This is a MVP of the new action, looks like we will have to merge it to master to trigger the workflow file and hammer out any bugs in next PR.