Recalculate ellipsoid elevation to orthometric #4210
Conversation
Withalion
requested review from
gabriel-bolbotina,
tomasMizera and
wonder-sk
Pull Request Test Coverage Report for Build 19369508469Details
💛 - Coveralls |
Add EGM96_15 geoid model, which recalculates ellipsoid altitudes returned by position providers. Expose this information in GPS information panel.
Withalion
force-pushed
the
feature/altitudes-converter
branch
from
8f9da6f to
131f97b
Compare
Provider returns now WGS84 ellipsoidal height on iOS
Create new 3D transform utils function. Fix coordinate order passing. Rework android 15+ Qt positioning workaround to VCPKG patch.
|
PR should be finally ready now for review |
|
@tomasMizera I think you could give it a look as well. |
| mapSettings->destinationCrs(), | ||
| crsGPS, | ||
| PositionKit::positionCRS(), | ||
| QgsCoordinateTransformContext(), |
There was a problem hiding this comment.
not directly relevant to this PR, but we should not use empty QgsCoordinateTransformContext() - we should use coordinate transform context from the active project everywhere, to avoid some subtle transformation errors (e.g. when project admin picks a non-default transform). Worth checking elsewhere too!
There was a problem hiding this comment.
I guess this is worth to do as a separate PR and go through the whole code base. I'll create a new issue for this and try to tackle it.
| QGeoPositionInfo location(QGeoCoordinate(newLocation.coordinate.latitude, | ||
| newLocation.coordinate.longitude, | ||
| - newLocation.altitude), | ||
| + newLocation.ellipsoidalAltitude), |
There was a problem hiding this comment.
is this safe? I have read ellipsoidalAltitude is only available in iOS 15+ ... do we support older versions? if we do, what happens there?
Also, what happens with external GNSS with mock location - is the ellipsoidal altitude populated correctly?
There was a problem hiding this comment.
- We support only iOS 16+, so there's no need to check for lower version.
- I'll have to check the external GNSS behaviour, haven't thought much about that.
There was a problem hiding this comment.
@wonder-sk there is not an easy way to debug that without access to the device, I'll ask our testing team to try it. However, I would postpone this issue for a bit and the whole bundle of enhancements will include also fix for this.
fixes #4165
fixes #2615
This PR adds EGM96_15 geoid model internally to recalculate ellipsoid heights returned by position providers to orthometric heights by default. Also, the information of which model was used is exposed to users in GPS information panel. There are some necessary fixes to Qt Positioning to force
InternalPositioningProviderto return ellipsoid height on both android and iOS.Besides this, some minor refactoring was done to prepare the rest of the codebase to support user supplied geoid models.