Skip to content

Conversation

@kaustuvpokharel
Copy link
Contributor

Changed the string to use rules instead of arg which doesn't properly translate

@kaustuvpokharel kaustuvpokharel linked an issue Oct 28, 2025 that may be closed by this pull request
@Withalion Withalion changed the base branch from dev/2025.8.0 to master November 11, 2025 09:59
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check other places for the plural form strings

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Pull Request Test Coverage Report for Build 19667093873

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 59.608%

Files with Coverage Reduction New Missed Lines %
mm/core/merginuserauth.cpp 9 68.24%
mm/core/merginapi.cpp 13 75.15%
Totals Coverage Status
Change from base Build 19633950309: -0.1%
Covered Lines: 8524
Relevant Lines: 14300

💛 - Coveralls

@gabriel-bolbotina gabriel-bolbotina marked this pull request as ready for review November 26, 2025 06:49
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@tomasMizera
Copy link
Collaborator

We'll test this on RC (cc @IvaKuklica @RastoHu )

@tomasMizera tomasMizera merged commit 97082a4 into master Dec 3, 2025
12 of 13 checks passed
@tomasMizera tomasMizera deleted the fix/pluralTranslations branch December 3, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong plural forms in translations

5 participants