Skip to content

Fix: MMInfoBox text elide hide fix #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev/2025.8.0
Choose a base branch
from
Open

Fix: MMInfoBox text elide hide fix #4173

wants to merge 2 commits into from

Conversation

@kaustuvpokharel
Copy link
Contributor

@kaustuvpokharel kaustuvpokharel commented Oct 21, 2025

Case:
MMInfoBox component as a hardcoded maximumLineCount = 2, while this is cause the text to hide for the workspace page which is using this MMInfoBox.

Fix:

  • Added an Api for now and for the future use, to let the lines for the description be configurable during the declaration of the component.
  • The default value is still 2, so it wouldn't break anything incase of no manual configuration, plus also doesn't break anything for existed MMInfoBoxes in the project.
Screenshot 2025-10-21 at 1 59 01 PM

@kaustuvpokharel kaustuvpokharel changed the title made the number of lines configurable for infoBox to configure it wit… Fix: MMInfoBox text elide hide fix Oct 21, 2025
@kaustuvpokharel kaustuvpokharel mentioned this pull request Oct 21, 2025
Open
@kaustuvpokharel kaustuvpokharel linked an issue Oct 21, 2025 that may be closed by this pull request
Adjust size of "A tip from us" section in "Name your workspace" page to avoid text eliding #3981
Open
Withalion
Withalion approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to also change it in gallery (MiscPage.qml), but besides that it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

@Withalion Withalion Withalion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adjust size of "A tip from us" section in "Name your workspace" page to avoid text eliding

4 participants

@kaustuvpokharel @tomasMizera @Withalion