Skip to content

fixed the space or rebound issue #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaustuvpokharel wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixed the space or rebound issue #4146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75c3747
Update version
Withalion Oct 6, 2025
be54e2f
fixed the space or rebound issue
kaustuvpokharel Oct 10, 2025
a10b732
rebound bug fix for the top scroll without forcing the last feature o…
kaustuvpokharel Oct 10, 2025
941a670
removing explicitly mentioned property from suggestion
kaustuvpokharel Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .zenodo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"description": "<p>Mergin Maps mobile app is a QGIS powered app for Android and iOS devices.</p>",
"license": "GPLv3",
"title": "Mergin Maps mobile app",
"version": "2025.7.0",
"version": "2025.8.0",
"upload_type": "software",
"publication_date": "2022-02-24",
"creators": [
Expand Down Expand Up @@ -39,7 +39,7 @@
"related_identifiers": [
{
"scheme": "url",
"identifier": "https://github.com/MerginMaps/mobile/tree/2025.7.0",
"identifier": "https://github.com/MerginMaps/mobile/tree/2025.8.0",
"relation": "isSupplementTo"
},
{
Expand Down
2 changes: 1 addition & 1 deletion CITATION.cff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cff-version: 2025.7.0
cff-version: 2025.8.0
message: "If you use this software, please cite it as below."
authors:
- family-names: "Martin"
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 3.22)

# Note: To update version use script/update_all_versions.bash
set(MM_VERSION_MAJOR "2025")
set(MM_VERSION_MINOR "7")
set(MM_VERSION_MINOR "8")
set(MM_VERSION_PATCH "0")

if (VCPKG_TARGET_TRIPLET MATCHES ".*ios.*")
Expand Down
4 changes: 4 additions & 0 deletions app/qml/layers/MMFeaturesListPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ MMComponents.MMPage {

width: parent.width

cacheBuffer: height
Copy link
Contributor

@Withalion Withalion Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't touch cacheBuffer it will break other things, look inside MMListView to find more info.

Copy link
Contributor Author

@kaustuvpokharel kaustuvpokharel Oct 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I believe it wouldn't break anything else, because as you scroll, new delegates need to be created and old ones destroyed technically in the list and this is the main cause for small stutters, and rebound issue.
And the 0 value in MMListView is only stopping the preloading, and it needs to be changed when list stutters because, it's only normal to stutter if the cacheBuffer for list is explicitly set 0.
Preloading 10-15 pixel before hand is no harm. Plus, it only changes for MMFeaturesListPage, not for whole MMListView so I am hoping this is the best approach for this specific case.

Copy link
Collaborator

@tomasMizera tomasMizera Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I believe it wouldn't break anything else...

Hi @kaustuvpokharel, this is why we set it to 0: #3435 .. chances are that the underlying QT bug is already fixed. If not, this would start to crash on macos/ios. Please try testing it out with >100 features in the list.

snapMode: ListView.SnapToItem

anchors {
top: searchBar.bottom
bottom: parent.bottom
Expand All @@ -73,6 +76,7 @@ MMComponents.MMPage {
}

footer: MMComponents.MMListSpacer {
id: spacer
height: __style.margin20 + ( root.hasToolbar ? 0 : __style.safeAreaBottom ) + ( addButton.visible ? addButton.height : 0 )
}
}
Expand Down
2 changes: 1 addition & 1 deletion vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"name": "merginmaps-mobile-app",
"description": "Collect. Share. Publish.",
"version": "2025.7.0",
"version": "2025.8.0",
"homepage": "https://github.com/merginmaps/mobile",
"dependencies": [
{
Expand Down
Loading