-
Notifications
You must be signed in to change notification settings - Fork 74
Feature/delete multiple feature #4119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/2025.8.0
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 18636599772Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests + updates as discussed :)
This reverts commit 75fb005.
Screen.Recording.2025-10-01.at.8.09.53.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still believe we can do better than using (s) in the text, maybe propagate through the signal if it's single or multi edit and then use ternary operator inline.
https://doc.qt.io/qt-6/i18n-source-translation.html#handle-plural-forms |
|
Hi @kaustuvpokharel - we can close the multiselect drawer after features are deleted. |
|
Noted |
Dialog is not closed after deletion is done
…lipleSelected Feature and skipped some potential tests cases of the entire class(multieditmanager)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add test for editing some points not just deleting
|
Moving to 2025.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few more things
75c3747 to
eb72e98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems alright now, let's see what @tomasMizera thinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments :)
| MMButton { | ||
| text: qsTr( "Delete" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hope screens are wide enough to incorporate both buttons without the need to scroll (in all languages 🙃)

Case:
Multiselect feature exists, but there is no way to delete all selected multiple feature at once, so pr includes the deleteMultipleSelect feature
Fix:
//! Deletes selected or toggled features upon called Q_INVOKABLE void deleteSelectedFeature();Tests:
testmultieditmanagerNote: this file is incomplete in a sense that it is missing other feature test cases which already existed inside the MultiEditManager class, as I was only requested to add tests for my new feature addition. But it needs more test cases to test other prior existing functions/methods.