Skip to content

Conversation

@kaustuvpokharel
Copy link
Contributor

@kaustuvpokharel kaustuvpokharel commented Sep 25, 2025

Case:

Multiselect feature exists, but there is no way to delete all selected multiple feature at once, so pr includes the deleteMultipleSelect feature

Fix:

  • Included feature deletion inside MultiEditManager class
    //! Deletes selected or toggled features upon called Q_INVOKABLE void deleteSelectedFeature();
  • Changed UI with delete button with respected UI
  • Added the drawer to verify the deletion before actually deleting it

Tests:

  • Added test cases only for checking deletion feature inside the new file testmultieditmanager
    Note: this file is incomplete in a sense that it is missing other feature test cases which already existed inside the MultiEditManager class, as I was only requested to add tests for my new feature addition. But it needs more test cases to test other prior existing functions/methods.

image

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Pull Request Test Coverage Report for Build 18636599772

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1014 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.1%) to 19.756%

Files with Coverage Reduction New Missed Lines %
mm/app/attributes/attributecontroller.cpp 1 76.83%
mm/app/layerfeaturesmodel.cpp 1 79.5%
mm/core/merginapi.cpp 1 75.22%
mm/app/multieditmanager.h 2 0.0%
build-mm-db/app/Input_autogen/EWIEGA46WW/moc_multieditmanager.cpp 25 15.31%
mm/app/multieditmanager.cpp 42 50.4%
build-mm-db/app/.rcc/qmlcache/Input_qml/main_qml.cpp 942 0.0%
Totals Coverage Status
Change from base Build 18284755654: 0.1%
Covered Lines: 14047
Relevant Lines: 71104

💛 - Coveralls

@kaustuvpokharel kaustuvpokharel marked this pull request as ready for review September 29, 2025 12:24
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests + updates as discussed :)

@kaustuvpokharel
Copy link
Contributor Author

image

@kaustuvpokharel
Copy link
Contributor Author

Screen.Recording.2025-10-01.at.8.09.53.PM.mov

Copy link
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still believe we can do better than using (s) in the text, maybe propagate through the signal if it's single or multi edit and then use ternary operator inline.

@tomasMizera
Copy link
Collaborator

I still believe we can do better than using (s) in the text, maybe propagate through the signal if it's single or multi edit and then use ternary operator inline.

https://doc.qt.io/qt-6/i18n-source-translation.html#handle-plural-forms

@tomasMizera
Copy link
Collaborator

Hi @kaustuvpokharel - we can close the multiselect drawer after features are deleted.

@kaustuvpokharel
Copy link
Contributor Author

Noted

Withalion
Withalion previously approved these changes Oct 2, 2025
@Withalion Withalion dismissed their stale review October 2, 2025 23:26

Dialog is not closed after deletion is done

…lipleSelected Feature and skipped some potential tests cases of the entire class(multieditmanager)
Copy link
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add test for editing some points not just deleting

@tomasMizera
Copy link
Collaborator

Moving to 2025.8.0

@tomasMizera tomasMizera changed the base branch from dev/2025.7.0 to dev/2025.8.0 October 10, 2025 11:49
Copy link
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few more things

Copy link
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright now, let's see what @tomasMizera thinks.

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments :)

Comment on lines +107 to +108
MMButton {
text: qsTr( "Delete" )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope screens are wide enough to incorporate both buttons without the need to scroll (in all languages 🙃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature to delete multiple selected features at once

4 participants