Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helper to interactively rebase the stack #465

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: add helper to interactively rebase the stack #465

merged 1 commit into from
Sep 24, 2024

Conversation

sileht
Copy link
Member

@sileht sileht commented Sep 20, 2024 •
edited
Loading

This adds mergify stack edit to interactively rebase the stack.

Add mergify stack becomes mergify stack push

mergify stack push being the default when mergify or mergify stack
is used.

@mergify mergify bot requested a review from a team September 20, 2024 19:10
jd
jd reviewed Sep 23, 2024
View reviewed changes
mergify_cli/__init__.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 23, 2024 06:43
@sileht sileht force-pushed the devs/sileht/restack/Ic488198667591d50d117b55e3d4dc2a22bd13b8d branch 8 times, most recently from 10140e1 to d8075e8 Compare September 24, 2024 07:28
jd
jd reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use something like click at some point?

mergify_cli/__init__.py Outdated Show resolved Hide resolved
@sileht sileht force-pushed the devs/sileht/restack/Ic488198667591d50d117b55e3d4dc2a22bd13b8d branch from d8075e8 to 7135ac4 Compare September 24, 2024 08:02
@mergify mergify bot requested a review from a team September 24, 2024 08:03
@sileht
feat: add helper to interactively rebase the stack
fd5a8a6 
This adds `mergify stack edit` to interactively rebase the stack.

Add `mergify stack` becomes `mergify stack push`

`mergify stack push` being the default when `mergify` or `mergify stack`
is used.

Change-Id: Ic488198667591d50d117b55e3d4dc2a22bd13b8d
@sileht sileht force-pushed the devs/sileht/restack/Ic488198667591d50d117b55e3d4dc2a22bd13b8d branch from 7135ac4 to fd5a8a6 Compare September 24, 2024 08:19
@sileht
Copy link
Member Author

sileht commented Sep 24, 2024

Should we use something like click at some point?

Maybe, the most annoying thing of argparse is args.Namespace is not typed

mergify bot added a commit that referenced this pull request Sep 24, 2024
@mergify
Merge of #465
62fcd75
@mergify mergify bot mentioned this pull request Sep 24, 2024
Closed
6 tasks
@mergify mergify bot merged commit 8e4e23b into main Sep 24, 2024
5 checks passed
@mergify mergify bot added the queued label Sep 24, 2024
@mergify mergify bot deleted the devs/sileht/restack/Ic488198667591d50d117b55e3d4dc2a22bd13b8d branch September 24, 2024 09:16
@mergify mergify bot removed the queued label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sileht @jd