Update text_summary() to support fixed designs from gs_design_ahr()#592
Merged
LittleBeannie merged 1 commit intoMerck:mainfrom Nov 7, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a fixed design is selected in the app, the following error appears below the summary table:
This is because
text_summary()is expecting a function when determining the upper bound.gsDesign2/R/text_summary.R
Line 192 in 5103d9c
A fixed design has no upper bound, so I fixed this by conditioning on
n_analysis > 1.Now the text summary for a fixed design works as below: