Import all functions once in R/gsDesign2-package.R, and remove the pkg:: qualifiers

[yihui]

No description provided.

[LittleBeannie]

Thanks for the comprehensive check and clean-up!

[jdblischak]

Personally I prefer the redundant imports at the top of each function. It gives you a better sense of how widely used a given dependency is, and how reliant any given function is on a particular dependency. I'm fine with going with whatever style the group decides on, but I wanted to note that I view the redundancy as a feature.

[nanxstats]

Apparently this is more of a personal preference and style guide thing so I'm afraid I can't be very helpful here.

The R Packages book dependencies chapter currently pushes a style that qualifies external namespaces with ::, without adding to NAMESPACE by default, unless it's used "a lot" or an operator. However, I don't think it's strictly enforced in their packages.

[yihui]

I don't really have a strong opinion on this. My original motivation was that I saw sometimes we use dplyr::, and sometimes we don't, so I wanted to clean up the unnecessary dplyr:: qualifiers. Then I moved on to remove other package qualifiers.

[jdblischak]

The R Packages book dependencies chapter

Later in that section, they also support defining @importFrom either separately for each function or in a central location. Thus I'm fine with migrating to the central location style.