Merged
Conversation
Contributor
|
Focus on |
nanxstats
force-pushed
the
ahr-blinded-test
branch
from
da289f1 to
7acc1c3
Compare
nanxstats
previously requested changes
Aug 2, 2024
Contributor
There was a problem hiding this comment.
Hey @DMuriuki I rebased your PR so the merge conflicts are now resolved. Please take a look at this failing test and make necessary updates:
── Failure ('test-independent-ahr_blinded.R:17:3'): Piecewise model hr and intervals must be aligned ──
`ahr_blinded(hr = c(1, 3), intervals = c(3, 4))` did not throw an error.
You can use
git clone -b ahr-blinded-test https://github.com/Merck/gsDesign2.git
to clone the latest version of this branch to local, install, fix the test, and push.
nanxstats
force-pushed
the
ahr-blinded-test
branch
from
a75b018 to
c4ef49a
Compare
nanxstats
reviewed
Aug 20, 2024
Contributor
nanxstats
left a comment
nanxstats
left a comment
There was a problem hiding this comment.
@LittleBeannie This PR is ready for review. 90% code coverage for ahr_blinded().
LittleBeannie
requested changes
Aug 22, 2024
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thanks, @DMuriuki and @nanxstats for the testing! Following, please find my comments.
Contributor
|
@LittleBeannie Great, I've just removed the non-informative and unrealistic test cases. |
LittleBeannie
approved these changes
Aug 29, 2024
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thanks a lot, @DMuriuki and @nanxstats !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test file for the
ahr_blinded()function.