Conversation
| # ----------------------------# | ||
| # find the difference between `AHR()` and different values of total_duration | ||
| foo <- function(x) { | ||
| ahr_diff <- function(x) { |
Collaborator
There was a problem hiding this comment.
shall we call it event_diff? Since basically it calculates the difference between the targeted events and the events at a calendar time...
nanxstats
suggested changes
Jun 7, 2023
Contributor
nanxstats
left a comment
nanxstats
left a comment
There was a problem hiding this comment.
I would appreciate it if you could make one small update: moving their function definitions outside of the exported functions.
Those functions are intentionally defined within a function. Because the only use case is to build a function that fit into root solving functions. How about we merge this PR and discuss the topic separately in #235? |
nanxstats
approved these changes
Jun 15, 2023
Contributor
|
Sure! Thanks for the renaming effort and suggestions. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address suggestion in #228