Unify cloud and mobile linter configs, add dependency check script on install#1987
Unify cloud and mobile linter configs, add dependency check script on install#1987fossephate wants to merge 2 commits intodevfrom
Conversation
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build⏳ Waiting for build... 🔀 Test Locallygh pr checkout 1987 |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 487086f66d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const nvmDir = process.env.NVM_DIR || `${process.env.HOME}/.nvm` | ||
| if (!fs.existsSync(`${nvmDir}/nvm.sh`)) { | ||
| console.warn("⚠️ nvm not found...") |
There was a problem hiding this comment.
The new check-deps.mjs references fs.existsSync(...) but never imports fs, so running bun run postinstall (which now calls checkDeps()) will throw a ReferenceError: fs is not defined and abort the install flow. This breaks dependency setup for anyone running the mobile postinstall script.
Useful? React with 👍 / 👎.
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" | ||
|
|
||
| npx lint-staged | ||
| npx lint-staged --no-stash |
There was a problem hiding this comment.
Removing the nvm init means npx lint-staged will fail on machines where Node is only available via nvm (common per repo guidance). In that environment, the hook can no longer find npx, so commits are blocked unless users manually export PATH or install a system Node.
Useful? React with 👍 / 👎.
3 participants
No description provided.