[pull] canary from vercel:canary #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…78574) Metadata can be dynamic without that being an error. A bug was introduced in a recent refactor where the presence of dynamic metadata was incorrectly interpreted as a sign that the metadata did not have a Suspense boundary around it. This would be a problem because metadata is now streaming however it was actually a misuse of the tracking flag and would incorrectly error if you had dynamic metadata at all. This fix addresses the incorrect invariant by removing it. there is arguably a second bug here in that InvariantError causes the validation of the page to be skipped but it doesn't error the build. That is concerning but not the focus of this change. regardless by removing the incorrect invariant error code the validation begins to work again as expected.
In dev when dynamicIO is enabled we perform a validating prerender to look for code that would be a build error in `next build`. However due to the construction of the earlier implementation of this code some validation messages were being suppressed because they were conveyed as a thrown error rather than through console.error. This change updates the mechanism by which we raise these issues in dev so they are consistently messaged. stacked on #78574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )