[pull] main from MaxMood96:main #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The test diffs show that we have better analysis/folds for 'add' (although we should at least have the simplifications independently, so we don't have the one-use restriction). This is related to solving regressions that would appear in transforms related to D111410, and that is part of a series of enhancements that may eventually helpi solve PR34047. https://alive2.llvm.org/ce/z/3tB9KG define i1 @src(i8 %x, i8 %C, i8 %C2) { %sub = sub nuw i8 %C2, %x %r = icmp slt i8 %sub, %C ret i1 %r } define i1 @tgt(i8 %x, i8 %C, i8 %C2) { %Cnot = xor i8 %C, -1 %C2not = xor i8 %C2, -1 %add = add nuw i8 %x, %C2not %r = icmp sgt i8 %add, %Cnot ret i1 %r }
This consolidates related folds that all have a similar use restriction that may not be necessary.
There is a stray tab character in a comment block. Replace the tab character with a space for consistency with other comments.
Upstream the character conversion pass. Translates entities of one CHARACTER KIND to another. By default the translation is to naively zero-extend or truncate a code point to fit the destination size. This patch is part of the upstreaming effort from fir-dev branch. Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Co-authored-by: Valentin Clement <clementval@gmail.com> Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D111405
There is an empty `namespace std` in `type_traits` which was originally used when `std::byte` was added in c97d8aa. At some point, the bitwise operators on `std::byte` got relocated but this empty namespace was left around. Remove it. Reviewed By: Quuxplusone, Mordante, #libc Differential Revision: https://reviews.llvm.org/D111512
Replace `TEST_NOEXCEPT_FALSE` directly with `noexcept(false)` in optional hash test which is only run in C++17 or later. `TEST_NOEXCEPT_FALSE` is only useful in C++03 context where `noexcept` isn't supported by clang. `TEST_NOEXCEPT_FALSE` now only has one remaining use in `hash_unique_ptr.pass.cpp`.
And rewrap a line at 80 columns while here. No behavior change.
..and use it. No behavior change.
Reviewed By: xbolva00 Differential Revision: https://reviews.llvm.org/D111215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )