Skip to content

Conversation

@Ki-Seki
Copy link
Member

@Ki-Seki Ki-Seki commented Aug 4, 2025

Description

Summary:

The upstream dependency virtualenv was upgraded to version 20.33.0, causing poetry to fail in executing commands based on the Python version in the virtual environment. This also likely caused the failure in locating the cache during the Set up Python ${{ matrix.python-version }} workflow step.

Related issues:

Currently, the temporary workaround is to downgrade virtualenv from 20.33.0 to 20.32.

Reviewer: @fridayL @CaralHsi @J1awei-Yang

Checklist:

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have added necessary documentation (if applicable) | 我已添加必要的文档(如果适用)
  • I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用)
  • I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人

@Ki-Seki Ki-Seki changed the base branch from main to dev August 4, 2025 14:04
@Ki-Seki Ki-Seki changed the title Hotfix/win-action fix: Windows workflow uses wrong Python version Aug 4, 2025
@Ki-Seki Ki-Seki force-pushed the hotfix/win-action branch from d8910eb to 6088f8e Compare August 4, 2025 14:21
@Ki-Seki Ki-Seki force-pushed the hotfix/win-action branch from 6088f8e to 1ad0e02 Compare August 4, 2025 14:30
@Ki-Seki Ki-Seki marked this pull request as ready for review August 4, 2025 14:43
Copilot AI review requested due to automatic review settings August 4, 2025 14:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a Windows workflow issue by installing a specific version of virtualenv to resolve compatibility problems with Poetry. The change addresses known issues with newer virtualenv versions that cause conflicts in Windows CI environments.

Key Changes

  • Adds virtualenv version pinning to ensure compatibility with Poetry on Windows
Comments suppressed due to low confidence (1)

.github/workflows/python-tests.yml:48

  • The virtualenv version 20.32 does not exist. The virtualenv package follows semantic versioning and the latest available versions are in the 20.x series but version 20.32 is not a valid release. Please verify the correct version number from the official virtualenv releases.
      run: pip install virtualenv==20.32

@Ki-Seki Ki-Seki marked this pull request as draft August 4, 2025 14:43
@Ki-Seki Ki-Seki marked this pull request as ready for review August 4, 2025 14:51
@Ki-Seki Ki-Seki changed the title fix: Windows workflow uses wrong Python version fix: a temporal workaround for the "virtualenv 20.33.0 breaks Poetry in GitHub Actions" Aug 4, 2025
@fridayL fridayL merged commit 36c110c into MemTensor:dev Aug 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants