Skip to content

docs: remove GitHub Discussions reference from contributing guide - #555

Merged
igorls merged 1 commit into
MemPalace:developfrom
grtninja:codex/fix-541-contributing-discussions
Aug 11, 2026
Merged

docs: remove GitHub Discussions reference from contributing guide#555
igorls merged 1 commit into
MemPalace:developfrom
grtninja:codex/fix-541-contributing-discussions

Conversation

@grtninja

Copy link
Copy Markdown
Contributor

Summary

  • remove the stale GitHub Discussions reference from CONTRIBUTING.md
  • direct questions and ideas to Discord or Issues while Discussions are disabled
  • keep the fix scoped to issue Contributing page mentions discussions #541 with no code-path changes

Why

Closes #541. The contributing guide currently points contributors to GitHub Discussions even though Discussions are not enabled for this repository.

Validation

  • python -m pytest tests/ -v --ignore=tests/benchmarks ✅ (567 passed)
  • ruff check .
  • ruff format --check . ⚠️ baseline repo drift in mempalace/normalize.py and mempalace/split_mega_files.py unrelated to this PR

@web3guru888

Copy link
Copy Markdown

Simple, correct fix. The Discussions link has been a minor papercut — new contributors would open the tab and see nothing there.

The replacement text ('Please use Discord or open an issue while GitHub Discussions are not enabled for this repo') is accurate and actionable. No behavior change, no risk.

LGTM.

@web3guru888 web3guru888 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #555 — docs: remove GitHub Discussions reference from contributing guide

Clean, accurate one-line fix. This closes #541 and addresses a real usability papercut: new contributors landing on the contributing guide and clicking "Discussions" would hit an empty or disabled tab, which erodes trust in the documentation.

What's done well:

The replacement text is concise and accurate: "Please use Discord or open an issue while GitHub Discussions are not enabled for this repo". It conveys three things correctly — the feature is currently off (not permanently removed), Discord is the right venue for open-ended questions, and issues remain appropriate for bugs and feature requests. That's the right framing.

The scope is exactly right. Nothing else in CONTRIBUTING.md is touched, which is exactly what this kind of fix should be: surgical and minimal. No risk of introducing unrelated changes.

One minor consideration:

The phrase "while GitHub Discussions are not enabled" is slightly ambiguous — it could mean either "until they're re-enabled" (a temporary situation) or "given that they're not enabled" (a current state). If Discussions are permanently disabled for this repo, "since GitHub Discussions are not enabled" would be slightly cleaner. If there's a chance they'll be re-enabled, "while" is fine. Either way it's clear enough.

Missing piece (not blocking):

It would be worth archiving or closing any issues/threads that currently reference the Discussions link directly, to prevent stale cross-links from resurfacing the problem. That's out of scope for this PR though.

Overall verdict:

Correct fix, right scope, no risk. LGTM — ready to merge.


Reviewed by MemPalace-AGI — autonomous research system with perfect memory

@grtninja
grtninja force-pushed the codex/fix-541-contributing-discussions branch from b2b3e61 to 5dcdd1e Compare April 11, 2026 07:52

@web3guru888 web3guru888 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix. LGTM.


[MemPalace-AGI integration — 540+ discoveries, 5,251 KG triples]

@bensig
bensig changed the base branch from main to develop April 11, 2026 22:21
@bensig
bensig requested a review from igorls as a code owner April 11, 2026 22:21
@igorls igorls added the documentation Improvements or additions to documentation label Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Backlog recheck on 2026-07-23: current develop still contains - **Discussions**: For questions and ideas, while GitHub Discussions remains disabled. This PR is still mergeable, has an approval, changes only that one documentation line, and still closes #541. No additional code changes are needed; ready for maintainer merge.

grtninja commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-08T22:00:38Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN / ready / mergeable=true; changed files=1
  • Checks/workflows observed at this head: Tests=success
  • Review state: 2 reviews / 0 review threads / 0 current unresolved
  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md
  • Exact-surface overlap: none detected among this open-PR union
  • Owner next bounded action: Owner: re-read the exact current head/diff, run the narrowest relevant validation, and keep maintainer/review follow-up moving without duplicate bot triggers.
  • Bot/review policy: no duplicate bot trigger and no human maintainer nudge; re-read this exact head/diff before any review reply.

This is a public-safe coordination receipt only. No push, merge, publication, credential, runtime, model, GPU, auth, or protected-reasoning mutation was performed or authorized by this pass.

grtninja commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-09T04:01:16Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN / ready / mergeable=true; changed files=1
  • Checks/workflows observed at this head: Tests=success
  • Review state: 2 reviews / 0 review threads / 0 current unresolved
  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md
  • Exact-surface overlap: none detected among this open-PR union
  • Owner next bounded action: Owner: re-read the latest review state on this exact head, run the narrowest relevant validation, and keep maintainer follow-up moving without duplicate bot triggers.
  • Bot/review policy: no duplicate bot trigger and no human maintainer nudge; re-read this exact head/diff before any review reply.

This is a public-safe coordination receipt only. No push, merge, publication, credential, runtime, model, GPU, auth, or protected-reasoning mutation was performed or authorized by this pass.

grtninja commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-09T10:00:48Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN / ready / mergeable=true; changed files=1
  • Checks/workflows observed at this head: Tests=success
  • Review state: 2 reviews / 0 review threads / 0 current unresolved
  • Current unresolved paths: none
  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md
  • Exact-surface overlap: none detected among this open-PR union
  • Owner next bounded action: Owner: re-read the exact current head/diff, run the narrowest relevant validation, and keep maintainer/review follow-up moving without duplicate bot triggers.
  • Bot/review policy: no duplicate bot trigger and no human maintainer-review nudge; re-read current head/diff before any reply.
  • Coordination boundary: public-safe packet only; no push, merge, publish, protected model/reasoning mutation, or process restart in this pass.

grtninja commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-09T16:01:56Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN / ready / mergeable=true; observed merge-state=see live inventory; changed files=1
  • Checks/workflows at this head: Tests=success
  • Review state: 2 reviews (latest APPROVED by web3guru888) / 0 review threads / 0 current unresolved
  • Current unresolved paths: none
  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md
  • Exact-surface overlap: none detected among this open-PR union
  • Owner next bounded action: Owner: re-read the exact current head/diff, run the narrowest relevant validation, and keep maintainer follow-up moving without duplicate bot triggers.
  • Bot/review policy: no duplicate bot trigger and no human maintainer-review nudge; re-read current head/diff before any reply.
  • Coordination boundary: public-safe packet only; no push, merge, publish, protected model/reasoning mutation, or process restart in this pass.

grtninja commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-09T22:00:57Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN / ready / mergeable=true; observed merge-state=see authoritative REST inventory; changed files=1
  • Checks/workflows at this head: Tests=success
  • Review state: 2 reviews (latest APPROVED by web3guru888) / 0 review threads / 0 current unresolved
  • Current unresolved paths: none
  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md
  • Exact-surface overlap: none detected among this open-PR union
  • Owner next bounded action: Owner: re-read the exact current head/diff, run the narrowest relevant validation, and keep maintainer follow-up moving without duplicate bot triggers.
  • Bot/review policy: no duplicate bot trigger and no human maintainer-review nudge; re-read current head/diff before any reply.
  • Coordination boundary: public-safe packet only; no push, merge, publish, protected model/reasoning mutation, or process restart in this pass.

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-10T04:00:32Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN / ready / mergeable=true; observed merge-state=see authoritative REST inventory; changed files=1
  • Checks/workflows at this head: Tests=success
  • Review state: 2 reviews / 0 review threads / 0 current unresolved
  • Current unresolved paths: none
  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md
  • Exact-surface overlap: none detected among this open-PR union
  • Owner next bounded action: Owner: re-read the exact current head/diff, run the narrowest relevant validation, and keep maintainer follow-up moving without duplicate bot triggers.
  • Bot/review policy: no duplicate bot trigger and no human maintainer-review nudge; re-read current head/diff before any reply.
  • Coordination boundary: public-safe packet only; no push, merge, publish, protected model/reasoning mutation, or process restart in this pass.

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-10T10:00:38Z

  • Fresh 10:01Z refresh: authoritative 34-PR union unchanged versus 04:00Z; no head, state, merge-state, review/thread, check, or changed-file deltas.

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide

  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / 1056018b521824a590400e36ccb540588f065895 (develop)

  • State: OPEN / ready / mergeable=true; observed merge-state=see authoritative REST inventory; changed files=1

  • Checks/workflows at this head: Tests=success

  • Review state: 2 reviews / 0 review threads / 0 current unresolved

  • Current unresolved paths: none

  • Contributor guidance recheck: AGENTS.md, CONTRIBUTING.md, SECURITY.md

  • Exact-surface overlap: none detected among this open-PR union

  • Owner next bounded action: Owner: re-read the exact current head/diff, run the narrowest relevant validation, and keep maintainer follow-up moving without duplicate bot triggers.

  • Bot/review policy: no duplicate bot trigger and no human maintainer-review nudge; re-read current head/diff before any reply.

  • Coordination boundary: public-safe packet only; no push, merge, publish, protected model/reasoning mutation, or process restart in this pass.

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-10 16:01:44Z

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-10 22:01:41Z

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-11 04:00:16Z

Copy link
Copy Markdown
Contributor Author

Current-head coordination packet — 2026-08-11 10:01:08Z

  • PR: docs: remove GitHub Discussions reference from contributing guide #555 — docs: remove GitHub Discussions reference from contributing guide
  • Exact head/base: 5dcdd1e14d11efdbb7c966d8c1ca2c537684a2bf / base 1056018b521824a590400e36ccb540588f065895 (develop)
  • State: OPEN; mergeability unknown (REST mergeable=unknown)
  • Fresh evidence: author/involves union refreshed at 2026-08-11T10:01:08Z; 34/34 PR info, reviews, threads, issue comments, checks, and file lists returned successfully. Direct REST refresh is 34/34; structural comparison vs 04:00Z has no head/base/state/draft/changed-file movement; three MemPalace mergeability fields are transient unknown and remain recheck-only. The 28 REST comment-count increments are the expected 04:00 coordination packets; no substantive post-04 issue-comment delta was observed.
  • Reviews/threads: 2 review submissions; 0 inline review threads; 0 currently unresolved.
  • Checks: Tests:success.
  • Changed surface: 1 file(s). Contributor guidance, exact-surface overlap, and current-head review state were rechecked.
  • Owner next action: Owner: re-read the current head and diff, address any current review findings, and run the narrowest relevant validation.
  • Priority blockers: none observed on the current review-thread snapshot.
  • Coordination guard: no duplicate bot trigger, no human maintainer nudge, no push/merge/publish, and no protected model/reasoning mutation. G07 Main Arbiter remains unchanged; this packet preserves the recipient's current model/reasoning.

@igorls igorls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wave 3 minimal for 3.7.0: LGTM. Docs/tests/tiny fix only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contributing page mentions discussions

3 participants