docs: remove GitHub Discussions reference from contributing guide - #555
Conversation
|
Simple, correct fix. The Discussions link has been a minor papercut — new contributors would open the tab and see nothing there. The replacement text ('Please use Discord or open an issue while GitHub Discussions are not enabled for this repo') is accurate and actionable. No behavior change, no risk. LGTM. |
web3guru888
left a comment
There was a problem hiding this comment.
PR #555 — docs: remove GitHub Discussions reference from contributing guide
Clean, accurate one-line fix. This closes #541 and addresses a real usability papercut: new contributors landing on the contributing guide and clicking "Discussions" would hit an empty or disabled tab, which erodes trust in the documentation.
What's done well:
The replacement text is concise and accurate: "Please use Discord or open an issue while GitHub Discussions are not enabled for this repo". It conveys three things correctly — the feature is currently off (not permanently removed), Discord is the right venue for open-ended questions, and issues remain appropriate for bugs and feature requests. That's the right framing.
The scope is exactly right. Nothing else in CONTRIBUTING.md is touched, which is exactly what this kind of fix should be: surgical and minimal. No risk of introducing unrelated changes.
One minor consideration:
The phrase "while GitHub Discussions are not enabled" is slightly ambiguous — it could mean either "until they're re-enabled" (a temporary situation) or "given that they're not enabled" (a current state). If Discussions are permanently disabled for this repo, "since GitHub Discussions are not enabled" would be slightly cleaner. If there's a chance they'll be re-enabled, "while" is fine. Either way it's clear enough.
Missing piece (not blocking):
It would be worth archiving or closing any issues/threads that currently reference the Discussions link directly, to prevent stale cross-links from resurfacing the problem. That's out of scope for this PR though.
Overall verdict:
Correct fix, right scope, no risk. LGTM — ready to merge.
Reviewed by MemPalace-AGI — autonomous research system with perfect memory
b2b3e61 to
5dcdd1e
Compare
web3guru888
left a comment
There was a problem hiding this comment.
Clean fix. LGTM.
[MemPalace-AGI integration — 540+ discoveries, 5,251 KG triples]
|
Backlog recheck on 2026-07-23: current |
|
Current-head coordination packet — 2026-08-08T22:00:38Z
This is a public-safe coordination receipt only. No push, merge, publication, credential, runtime, model, GPU, auth, or protected-reasoning mutation was performed or authorized by this pass. |
|
Current-head coordination packet — 2026-08-09T04:01:16Z
This is a public-safe coordination receipt only. No push, merge, publication, credential, runtime, model, GPU, auth, or protected-reasoning mutation was performed or authorized by this pass. |
|
Current-head coordination packet — 2026-08-09T10:00:48Z
|
|
Current-head coordination packet — 2026-08-09T16:01:56Z
|
|
Current-head coordination packet — 2026-08-09T22:00:57Z
|
|
Current-head coordination packet — 2026-08-10T04:00:32Z
|
|
Current-head coordination packet — 2026-08-10T10:00:38Z
|
|
Current-head coordination packet — 2026-08-10 16:01:44Z
|
|
Current-head coordination packet — 2026-08-10 22:01:41Z
|
|
Current-head coordination packet — 2026-08-11 04:00:16Z
|
|
Current-head coordination packet — 2026-08-11 10:01:08Z
|
igorls
left a comment
There was a problem hiding this comment.
Wave 3 minimal for 3.7.0: LGTM. Docs/tests/tiny fix only.
Summary
CONTRIBUTING.mdWhy
Closes #541. The contributing guide currently points contributors to GitHub Discussions even though Discussions are not enabled for this repository.
Validation
python -m pytest tests/ -v --ignore=tests/benchmarks✅ (567 passed)ruff check .✅ruff format --check .mempalace/normalize.pyandmempalace/split_mega_files.pyunrelated to this PR