Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Support camelcase jsonl names #30

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Draft: Support camelcase jsonl names #30

merged 1 commit into from
Nov 2, 2021

Conversation

pnadolny13
Copy link

Closes: #29

Problem

Default to case insensitive for jsonl records.

Types of changes

What types of changes does your code introduce to PipelineWise?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@pnadolny13 pnadolny13 changed the title Draft: Default to case insensitive for jsonl records to support camelcase names Draft: Support camelcase jsonl names Oct 29, 2021
@aaronsteers aaronsteers marked this pull request as ready for review November 2, 2021 04:43
@aaronsteers aaronsteers self-requested a review November 2, 2021 04:43
@aaronsteers
Copy link

@pnadolny13 - Thanks for submitting! I've approved. Feel free to merge - if you have permissions - or just ping me again to merge when ready if permissions are not there.

@pnadolny13
Copy link
Author

@pnadolny13 - Thanks for submitting! I've approved. Feel free to merge - if you have permissions - or just ping me again to merge when ready if permissions are not there.

@aaronsteers awesome, thanks! It looks like I don't have merge permission. Can you merge it for me whenever you have a minute?

@aaronsteers aaronsteers merged commit ea26980 into MeltanoLabs:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camelCase Records are null
2 participants