-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for /32 (/128) networks and perNodeBlockSize 1 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasrem
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A couple of questions and nits
- Add support for /31(/127) and /32(/128) subnets - Add single IP allocations
ykulazhenkov
force-pushed
the
pr-single-ip-pools
branch
from
October 15, 2024 09:35
5dd0e8d
to
07ef882
Compare
@vasrem Thanks for the review! I addressed your comments. |
rollandf
approved these changes
Oct 15, 2024
adrianchiris
approved these changes
Oct 15, 2024
vasrem
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for single IP ranges/subnets in all places:
IPPool perNodeBlockSize 1
IPPool /32
IPPool /31
CIDRPool /32
CIDRPool /128
perNodeBlockSize: 1
- useful when you need to deploy one and only one instance of a service per node and you need to make sure that this instance is always have the same predictable IP.CIDRPool /32
- useful to assign IPs for loopback interfaces on routers