Allow more tests to run with CUDA #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blochl
requested review from
amirancel,
guyshafranNbaLeaguePassPlugin,
nshamshoum,
halaAwisat,
YossiKendel,
RavidRothfeld,
ErezAshkenazi and
Maya705
halaAwisat
approved these changes
Dec 9, 2024
Include ib_send_bw in CUDA tests, as it looks like with the recent versions of perftest it is supported with CUDA. Signed-off-by: Leonid Bloch <lbloch@nvidia.com>
ib_send_lat can actually work with CUDA, but with message sizes only higher than 32 (otherwise libmlx5 will try to inline the data to a WQE, which will cause the CPU to try to memcpy the CUDA buffer). So if before all the ib_send_lat tests were skipped with CUDA, now only the ones with the small message sizes will be. Signed-off-by: Leonid Bloch <lbloch@nvidia.com>
RavidRothfeld
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more fine-grained about which tests are able to run with CUDA. Thanks @halaAwisat for the suggestion to do this and the testing.