Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing brew packages in go-releaser #138

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Removing brew packages in go-releaser #138

merged 1 commit into from
Nov 25, 2023

Conversation

Melkeydev
Copy link
Owner

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

Please include a description of the problem or feature this PR is addressing.

Description of Changes:

  • Item 1
  • Item 2

Checklist

  • I have self-reviewed the changes being requested
  • I have updated the documentation (if applicable)

Copy link
Contributor

@mikelerch mikelerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure unrelated whitespace changes are addressed in a separate PR from now on. Preferably a linter for YAML files is introduced as well, or at the least, a .editorconfig file.

@muandane
Copy link
Contributor

Yes that should be it for brew removal

@muandane
Copy link
Contributor

although can you check what's the scope on the github token ? for example this is the token i use for my goreleaser pipeline (i just want to know why it's broken not force adding brew installation to this repo)
image

@muandane
Copy link
Contributor

btw need to remove brew install method in README.md

@Ujstor
Copy link
Collaborator

Ujstor commented Nov 25, 2023

@muandane There is my PR with changes in readme, I have removed 'brew install' from it

@Melkeydev
Copy link
Owner Author

although can you check what's the scope on the github token ? for example this is the token i use for my goreleaser pipeline (i just want to know why it's broken not force adding brew installation to this repo) image

I am not sure how to find this token - can you DM on discord to instruct me where to find the scopes?

@Melkeydev Melkeydev merged commit 7c7bc8b into main Nov 25, 2023
@Ujstor Ujstor deleted the removing-brew branch November 28, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants