Add Midnight Support

[JanRogge]

I had the Addon running since 12.0.0 launch and noticed no problems so far.

This also adds a missing TWW World Boss and the Midnight World Bosses.

[Meivyn]

Thanks for the PR, but I believe this is not complete. I've noticed an issue with the availability status:

AdventureGuideLockouts/AdventureGuideLockouts.lua

Line 227 in c33b14b

isAvailable = C_TaskQuest.GetQuestTimeLeftMinutes(self.worldBosses[instanceIndex].encounters[encounterIndex].questID) ~= nil

This is very inconsistent and doesn't work correctly in some cases with the new world bosses. I didn't take the time to look at it just yet.

[JanRogge]

I see what you mean the problem seems to be that some World Quests like for the gobfather dont have an expiration time. Even Addons like WorldQuestList show no Timer for it because of this your check didnt work.

I've now changed it to isAvailable = C_TaskQuest.IsActive(self.worldBosses[instanceIndex].encounters[encounterIndex].questID) which seems to work fine from my testing killing one TWW and one DF World Boss.

Sadly no World Bosses are up on Beta so cant test there :(

[Meivyn]

Yeah that's what I attempted locally but this breaks some other world bosses of previous expansions.

I believe it fails to see Undermine too, something like that. I added some test code and it was obviously wrong but can't tell exactly what was wrong at the moment.

[JanRogge]

Weird for me it saw Undermine with that change and not without it.
But i see what you mean looks like Pandaria, Draenor and Invasion Points are not working but they dont work with either GetQuestTimeLeftMinutes or IsActive since they dont have an active World Quest so its not getting any more broken then the current release.

I guess a fix for Pandaria and Draenor would need some special case like the warfront bosses that just says they are always available since they dont rotate.
Invasion Points are a bit harder i guess but i didnt look into that.
But these legacy fixes could be done separately.

[Meivyn]

Weird for me it saw Undermine with that change and not without it.

Yeah, it was either. I knew Undermine was wrong.

But i see what you mean looks like Pandaria, Draenor and Invasion Points are not working

Pandaria should work. Draenor and Invasion Points are special cases and have always been broken. I didn't take the time to search for a potential workaround yet.

[JanRogge]

Pandaria should work.

Maybe i overlooked that i just tried C_TaskQuest.GetQuestTimeLeftMinutes and C_TaskQuest.isActive with the QuestIds saved in the file and both always returned nothing/false. I didnt test it in Person.

Wasnt Draenor also the case like Pandaria where there were not rotating World Bosses? Don't quite remember anymore since back in the days respawns were more limiting than lockouts :D

Anyway i think the implementation of this PR should work for everything that is relevant enough if they dont change anything with Midnights World Boss implementation.

If you dont wanna rush anything its fine just close this PR then ^^

[Meivyn]

Pandaria bosses should be available by default.

I'm pretty sure I noticed issues with IsActive so I'll test it again before merging.

[Meivyn]

From what I could see, the issue happens when using it with older content, but it was because of a code issue. C_TaskQuest.GetQuestTimeLeftMinutes also doesn't work when the player is at home anyway.